Skip to content
This repository was archived by the owner on Sep 10, 2021. It is now read-only.

Commit 9d42fd3

Browse files
committed
Minor fix
- Fixed queues not being disposed
1 parent d3bc8e3 commit 9d42fd3

File tree

3 files changed

+6
-15
lines changed

3 files changed

+6
-15
lines changed

samples/Example.General/Program.cs

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -77,16 +77,9 @@ static async Task AsyncMain(string[] args) {
7777
});
7878

7979
// attach
80-
//await TestNode.AttachAsync("auth:login", RpcBehaviour.Bind<ITest001>(new Test001(Guid.NewGuid())));
81-
82-
// subscribe
83-
(await TestNode.SubscribeAsync("auth:login.happened"))
84-
.AsObservable().Subscribe(new EventObserver());
85-
86-
await TestNode.EmitAsync("auth:login.happened", new LoginRequestMsg() {
87-
Password = "password",
88-
Username = "username"
89-
}).ConfigureAwait(false);
80+
Service service = await TestNode.AttachAsync("auth:login", RpcBehaviour.Bind<ITest001>(new Test001(Guid.NewGuid())));
81+
82+
service.Dispose();
9083

9184
await Task.Delay(50000);
9285
}

src/Holon/Holon.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,19 @@
22

33
<PropertyGroup>
44
<TargetFramework>netstandard1.6</TargetFramework>
5-
<Version>0.1.6.3</Version>
5+
<Version>0.1.7</Version>
66
<Authors>Alan Doherty</Authors>
77
<Company>Alan Doherty</Company>
88
<Description>A minimal service and event bus with additional support for RPC</Description>
99
<Copyright>BattleCrate Ltd 2018</Copyright>
1010
<PackageProjectUrl>https://github.com/alandoherty/holon-net</PackageProjectUrl>
1111
<RepositoryUrl>https://github.com/alandoherty/holon-net</RepositoryUrl>
1212
<RepositoryType>git</RepositoryType>
13-
<AssemblyVersion>0.1.6.3</AssemblyVersion>
13+
<AssemblyVersion>0.1.7.0</AssemblyVersion>
1414
<PackageLicenseUrl>https://github.com/alandoherty/holon-net/blob/master/LICENSE</PackageLicenseUrl>
1515
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
1616
<PackageIconUrl>https://s3-eu-west-1.amazonaws.com/assets.alandoherty.co.uk/github/holon-net-nuget.png</PackageIconUrl>
17-
<FileVersion>0.1.6.3</FileVersion>
17+
<FileVersion>0.1.7.0</FileVersion>
1818
</PropertyGroup>
1919

2020
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">

src/Holon/Services/Service.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -294,11 +294,9 @@ private async Task ServiceHandleAsync(Envelope envelope) {
294294
}
295295

296296
void IObserver<InboundMessage>.OnCompleted() {
297-
throw new NotImplementedException();
298297
}
299298

300299
void IObserver<InboundMessage>.OnError(Exception error) {
301-
throw new NotImplementedException();
302300
}
303301

304302
async void IObserver<InboundMessage>.OnNext(InboundMessage message) {

0 commit comments

Comments
 (0)