Skip to content

Commit a3c8e21

Browse files
Abbondanzofacebook-github-bot
authored andcommitted
Enable vector drawable support by default (facebook#48347)
Summary: Pull Request resolved: facebook#48347 Vector drawable support was added behind a feature flag in facebook#45354 and is ready to release more widely. This change is effectively the same as removing the feature flag but allows our holdout to continue until mid-January. Changelog: [Internal] Reviewed By: rshest Differential Revision: D67482531 fbshipit-source-id: 1733c4748f79fd4df72f531a24efcbd8a7822611
1 parent 6dd4195 commit a3c8e21

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<d21071fcbf501d1e7aba6b227ef74351>>
7+
* @generated SignedSource<<ad4ecf46a017b05a22046b772504f889>>
88
*/
99

1010
/**
@@ -95,7 +95,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
9595

9696
override fun lazyAnimationCallbacks(): Boolean = false
9797

98-
override fun loadVectorDrawablesOnImages(): Boolean = false
98+
override fun loadVectorDrawablesOnImages(): Boolean = true
9999

100100
override fun traceTurboModulePromiseRejectionsOnAndroid(): Boolean = false
101101

packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<14f964cf6d43943bdeed783d28c231e0>>
7+
* @generated SignedSource<<570853d015d4f41ef4eb0a7896a96e96>>
88
*/
99

1010
/**
@@ -172,7 +172,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
172172
}
173173

174174
bool loadVectorDrawablesOnImages() override {
175-
return false;
175+
return true;
176176
}
177177

178178
bool traceTurboModulePromiseRejectionsOnAndroid() override {

packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ const definitions: FeatureFlagDefinitions = {
391391
},
392392
},
393393
loadVectorDrawablesOnImages: {
394-
defaultValue: false,
394+
defaultValue: true,
395395
metadata: {
396396
dateAdded: '2024-07-12',
397397
description:

packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<a35c5b22c0f20cb50ceaf56a856c9c8f>>
7+
* @generated SignedSource<<fb2e049d649b9bf7ef6bd0e26523b4ef>>
88
* @flow strict
99
*/
1010

@@ -337,7 +337,7 @@ export const lazyAnimationCallbacks: Getter<boolean> = createNativeFlagGetter('l
337337
/**
338338
* Adds support for loading vector drawable assets in the Image component (only on Android)
339339
*/
340-
export const loadVectorDrawablesOnImages: Getter<boolean> = createNativeFlagGetter('loadVectorDrawablesOnImages', false);
340+
export const loadVectorDrawablesOnImages: Getter<boolean> = createNativeFlagGetter('loadVectorDrawablesOnImages', true);
341341
/**
342342
* Enables storing js caller stack when creating promise in native module. This is useful in case of Promise rejection and tracing the cause.
343343
*/

0 commit comments

Comments
 (0)