Skip to content

Commit d47b7f7

Browse files
alanleedevfacebook-github-bot
authored andcommitted
Add default case to EventEmitterH generator switch statement
Summary: Adds a default case to the switch statement in GenerateEventEmitterH.js to fix compiler warnings about unhandled enum values in upcoming diff ``` [info] buck-out/v2/gen/fbsource/xplat/js/react-native-github/__generate_event_emitter_h-FBReactNativeSpec__/6c08ec662a69b177/out/EventEmitters.h:178:5: error: 'switch' missing 'default' label [-Werror,-Wswitch-default] [info] 178 | switch (value) { [info] | ^ [info] 1 error generated. [info] [2025-12-17T13:42:51.990-08:00] [info] [2025-12-17T13:42:51.990-08:00] Action sub-errors produced by error handlers: [info] - [apple_cxx_error][switch_default] buck-out/v2/gen/fbsource/xplat/js/react-native-github/__generate_event_emitter_h-FBReactNativeSpec__/6c08ec662a69b177/out/EventEmitters.h:178:5 'switch' missing 'default' label [-Wswitch-default] [info] Hint: https://fburl.com/apple_build_errors/missing_switch_default_label [info] [info] BUILD FAILED ``` Changelog: [Internal] Differential Revision: D89513261
1 parent 3650ae3 commit d47b7f7

File tree

4 files changed

+5
-0
lines changed

4 files changed

+5
-0
lines changed

packages/react-native-codegen/e2e/deep_imports/__tests__/components/__snapshots__/GenerateEventEmitterH-test.js.snap

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -269,6 +269,7 @@ class EventPropsNativeComponentViewEventEmitter : public ViewEventEmitter {
269269
switch (value) {
270270
case OnOrientationChangeOrientation::Landscape: return \\"landscape\\";
271271
case OnOrientationChangeOrientation::Portrait: return \\"portrait\\";
272+
default: return \\"\\";
272273
}
273274
}
274275

packages/react-native-codegen/e2e/namespaced/__tests__/components/__snapshots__/GenerateEventEmitterH-test.js.snap

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -269,6 +269,7 @@ class EventPropsNativeComponentViewEventEmitter : public ViewEventEmitter {
269269
switch (value) {
270270
case OnOrientationChangeOrientation::Landscape: return \\"landscape\\";
271271
case OnOrientationChangeOrientation::Portrait: return \\"portrait\\";
272+
default: return \\"\\";
272273
}
273274
}
274275

packages/react-native-codegen/src/generators/components/GenerateEventEmitterH.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ const EnumTemplate = ({
109109
static char const *toString(const ${enumName} value) {
110110
switch (value) {
111111
${toCases}
112+
default: return "";
112113
}
113114
}
114115
`.trim();

packages/react-native-codegen/src/generators/components/__tests__/__snapshots__/GenerateEventEmitterH-test.js.snap

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -513,6 +513,7 @@ class EventsNativeComponentEventEmitter : public ViewEventEmitter {
513513
switch (value) {
514514
case OnArrayEventTypeString_enum_event_prop::YES: return \\"YES\\";
515515
case OnArrayEventTypeString_enum_event_prop::NO: return \\"NO\\";
516+
default: return \\"\\";
516517
}
517518
}
518519
@@ -543,6 +544,7 @@ class EventsNativeComponentEventEmitter : public ViewEventEmitter {
543544
switch (value) {
544545
case OnOrientationChangeOrientation::Landscape: return \\"landscape\\";
545546
case OnOrientationChangeOrientation::Portrait: return \\"portrait\\";
547+
default: return \\"\\";
546548
}
547549
}
548550

0 commit comments

Comments
 (0)