[logging] Remove an unnecessary trick/hack

We just want to use `nameof` here. We don't need fancy reflection.

Fixes alanmcgovern/monotorrent#448

Author: alanmcgovern

Mono.Nat/AsyncExtensions.cs

@@ -8,7 +8,7 @@ namespace Mono.Nat
 {
     static class AsyncExtensions
     {
-        static Logger Log { get; } = Logger.Create ();
+        static Logger Log { get; } = Logger.Create (nameof (AsyncExtensions));
 
         class SemaphoreSlimDisposable : IDisposable
         {

Mono.Nat/Logging/Logger.cs

@@ -42,13 +42,8 @@ public class Logger
         /// </summary>
         public static Func<string, ILogger> Factory { get; set; }
 
-        [MethodImpl (MethodImplOptions.NoInlining)]
-        internal static Logger Create ()
-        {
-            var callingClassName = new StackFrame (1).GetMethod ().ReflectedType.FullName;
-            var writer = Factory?.Invoke (callingClassName);
-            return new Logger (writer);
-        }
+        internal static Logger Create (string callingClassName)
+            => new Logger (Factory?.Invoke (callingClassName));
 
         ILogger Writer { get; }
 

Mono.Nat/Mono.Nat.csproj

@@ -45,7 +45,7 @@
 
 	<Target Name="SetAssemblyVersion" BeforeTargets="GetAssemblyVersion" Condition="'$(RestoreSuccess)' == 'true' And '$(Configuration)' == 'Release' " DependsOnTargets="GitVersion">
 		<PropertyGroup>
-			<MonoNatFileVersion>3.0.1</MonoNatFileVersion>
+			<MonoNatFileVersion>3.0.2</MonoNatFileVersion>
 			<MonoNatInformationalVersion>$(MonoNatFileVersion)-$(GitBranch)+$(GitCommit)</MonoNatInformationalVersion>
 
 			<AssemblyVersion Condition="'$(AssemblyVersion)' == ''">$(MonoNatABIVersion)</AssemblyVersion>

Mono.Nat/Pmp/Searchers/PmpSearcher.cs

@@ -42,7 +42,7 @@ namespace Mono.Nat.Pmp
 {
     class PmpSearcher : Searcher
     {
-        static Logger Log { get; } = Logger.Create ();
+        static Logger Log { get; } = Logger.Create (nameof (PmpSearcher));
 
         internal static PmpSearcher Create ()
         {

Mono.Nat/Searcher.cs

@@ -38,7 +38,7 @@ namespace Mono.Nat
 {
     abstract class Searcher : ISearcher
     {
-        static Logger Log { get; } = Logger.Create ();
+        static Logger Log { get; } = Logger.Create (nameof (Searcher));
 
         protected static readonly TimeSpan SearchPeriod = TimeSpan.FromMinutes (5);
 

Mono.Nat/Upnp/Messages/Responses/ResponseMessage.cs

@@ -7,7 +7,7 @@ namespace Mono.Nat.Upnp
 {
     class ResponseMessage
     {
-        static Logger Log { get; } = Logger.Create ();
+        static Logger Log { get; } = Logger.Create (nameof (ResponseMessage));
 
         public static ResponseMessage Decode (UpnpNatDevice device, string message)
         {

Mono.Nat/Upnp/Searchers/UpnpSearcher.cs

@@ -46,7 +46,7 @@ namespace Mono.Nat.Upnp
 {
     class UpnpSearcher : Searcher
     {
-        static Logger Log { get; } = Logger.Create ();
+        static Logger Log { get; } = Logger.Create (nameof (UpnpSearcher));
 
         static readonly IList<string> SupportedServices = new List<string> {
             "urn:schemas-upnp-org:service:WANIPConnection:1",

Mono.Nat/Upnp/UpnpNatDevice.cs

@@ -38,7 +38,7 @@ namespace Mono.Nat.Upnp
 {
     sealed class UpnpNatDevice : NatDevice, IEquatable<UpnpNatDevice>
     {
-        static Logger Log { get; } = Logger.Create ();
+        static Logger Log { get; } = Logger.Create (nameof (UpnpNatDevice));
 
         /// <summary>
         /// The url we can use to control the port forwarding