Skip to content

Commit 48ef888

Browse files
committed
Use .NET 6.0 methods which are lower allocation
1 parent 4f1a615 commit 48ef888

File tree

4 files changed

+19
-3
lines changed

4 files changed

+19
-3
lines changed

Mono.Nat.Console/Mono.Nat.Console.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<Project Sdk="Microsoft.NET.Sdk">
33

44
<PropertyGroup>
5-
<TargetFramework>net472</TargetFramework>
5+
<TargetFrameworks>net6.0;net472</TargetFrameworks>
66
<OutputType>Exe</OutputType>
77
</PropertyGroup>
88

Mono.Nat/Mono.Nat.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
<PropertyGroup>
77
<GitThisAssembly>false</GitThisAssembly>
8-
<TargetFrameworks>netstandard2.0;netstandard2.1</TargetFrameworks>
8+
<TargetFrameworks>net6.0;netstandard2.1;netstandard2.0</TargetFrameworks>
99

1010
<MonoNatABIVersion>3.0.0.0</MonoNatABIVersion>
1111
<GenerateDocumentationFile>true</GenerateDocumentationFile>
@@ -45,7 +45,7 @@
4545

4646
<Target Name="SetAssemblyVersion" BeforeTargets="GetAssemblyVersion" Condition="'$(RestoreSuccess)' == 'true' And '$(Configuration)' == 'Release' " DependsOnTargets="GitVersion">
4747
<PropertyGroup>
48-
<MonoNatFileVersion>3.0.3</MonoNatFileVersion>
48+
<MonoNatFileVersion>3.0.4</MonoNatFileVersion>
4949
<MonoNatInformationalVersion>$(MonoNatFileVersion)-$(GitBranch)+$(GitCommit)</MonoNatInformationalVersion>
5050

5151
<AssemblyVersion Condition="'$(AssemblyVersion)' == ''">$(MonoNatABIVersion)</AssemblyVersion>

Mono.Nat/Pmp/PmpNatDevice.cs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,14 +81,22 @@ static async Task<ResponseMessage> SendMessageAsync (IPEndPoint deviceEndpoint,
8181
tcs.Token.Register (() => udpClient.Dispose ());
8282

8383
var data = message.Encode ();
84+
#if NETSTANDARD2_0 || NETSTANDARD2_1
8485
await udpClient.SendAsync (data, data.Length, deviceEndpoint).ConfigureAwait (false);
86+
#else
87+
await udpClient.SendAsync (data, deviceEndpoint, CancellationToken.None).ConfigureAwait (false);
88+
#endif
8589
var receiveTask = ReceiveMessageAsync (udpClient);
8690

8791
var delay = PmpConstants.RetryDelay;
8892
for (int i = 0; i < PmpConstants.RetryAttempts && !receiveTask.IsCompleted; i++) {
8993
await Task.Delay (delay).ConfigureAwait (false);
9094
delay = TimeSpan.FromTicks (delay.Ticks * 2);
95+
#if NETSTANDARD2_0 || NETSTANDARD2_1
9196
await udpClient.SendAsync (data, data.Length, deviceEndpoint).ConfigureAwait (false);
97+
#else
98+
await udpClient.SendAsync (data, deviceEndpoint, tcs.Token).ConfigureAwait (false);
99+
#endif
92100
}
93101

94102
tcs.Dispose ();
@@ -98,7 +106,11 @@ static async Task<ResponseMessage> SendMessageAsync (IPEndPoint deviceEndpoint,
98106
static async Task<ResponseMessage> ReceiveMessageAsync (UdpClient udpClient)
99107
{
100108
while (true) {
109+
#if NETSTANDARD2_0 || NETSTANDARD2_1
101110
var receiveResult = await udpClient.ReceiveAsync ().ConfigureAwait (false);
111+
#else
112+
var receiveResult = await udpClient.ReceiveAsync (CancellationToken.None).ConfigureAwait (false);
113+
#endif
102114
var message = ResponseMessage.Decode (receiveResult.Buffer);
103115
return message;
104116
}

Mono.Nat/Searcher.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,11 @@ async Task ListenOneAsync (System.Net.Sockets.UdpClient udpClient, CancellationT
9696
{
9797
while (!token.IsCancellationRequested) {
9898
try {
99+
#if NETSTANDARD2_0 || NETSTANDARD2_1
99100
var data = await udpClient.ReceiveAsync ();
101+
#else
102+
var data = await udpClient.ReceiveAsync (token);
103+
#endif
100104
var localEndPoint = (IPEndPoint) udpClient.Client.LocalEndPoint;
101105
token.ThrowIfCancellationRequested ();
102106

0 commit comments

Comments
 (0)