Skip to content

Commit 2125f4f

Browse files
authored
Merge pull request #32 from lanzhiwang/fix-chart-dependencies
update chart dependencies version in the script
2 parents e46847c + 2a74c9e commit 2125f4f

File tree

4 files changed

+26
-9
lines changed

4 files changed

+26
-9
lines changed

Makefile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
TOPDIR=$(shell dirname $(realpath $(firstword $(MAKEFILE_LIST))))
2+
3+
update_chart_dependencies_version:
4+
$(TOPDIR)/script/update_chart_dependencies_version.sh

charts/kubeflow/Chart.yaml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ description: |
99
but to provide a straightforward way to deploy best-of-breed
1010
open-source systems for ML to diverse infrastructures.
1111
Anywhere you are running Kubernetes, you should be able to run Kubeflow.
12-
1312
# 卸载须知:
1413
#
1514
# 1. 执行 helm delete 之后,注意需要执行下面命令确保 profile 资源删除:
@@ -34,18 +33,18 @@ dependencies:
3433
version: "1.5.0"
3534
alias: cert-manager
3635
condition: cert-manager.enabled
36+
- name: dex
37+
version: "2.31.2"
38+
condition: dex.enabled
3739
- name: istio
3840
version: "1.14.1"
3941
condition: istio.enabled
42+
- name: knative-serving
43+
version: 1.2.5
4044
- name: minio
4145
version: "1.0"
4246
condition: minio.enabled
43-
- name: dex
44-
version: "1.0"
45-
condition: dex.enabled
46-
- name: knative-serving
47-
version: v0.22.1
4847
maintainers:
4948
- name: typhoonzero
5049
51-
appVersion: "1.5.0"
50+
appVersion: "1.6.1"
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
apiVersion: v2
22
name: knative-serving
3-
version: "v1.2.5"
3+
version: "1.2.5"
44
kubeVersion: ">=1.17.0"
55
description: "knative serving for kubeflow-chart."
66
type: application
@@ -9,4 +9,4 @@ sources:
99
maintainers:
1010
- name: typhoonzero
1111
12-
appVersion: "v1.2.5"
12+
appVersion: "1.2.5"
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
#!/usr/bin/env bash
2+
set -e
3+
4+
root_dir=$(dirname $(dirname $(realpath $0)))
5+
chart_dir=${root_dir}/charts
6+
7+
length=$(yq '.dependencies | length' ${chart_dir}/kubeflow/Chart.yaml)
8+
number=0
9+
while [[ ${number} -lt ${length} ]] ; do
10+
name=$(echo ${number} | xargs -I {} yq e '.dependencies[{}].name' ${chart_dir}/kubeflow/Chart.yaml)
11+
version=$(echo ${name} | xargs -I {} yq e '.version' ${chart_dir}/kubeflow/charts/{}/Chart.yaml)
12+
eval "yq e '.dependencies["${number}"].version = \""${version}"\"' -i ${chart_dir}/kubeflow/Chart.yaml"
13+
((number = number + 1))
14+
done

0 commit comments

Comments
 (0)