Remove redundant test on DOT_NUM_THREADS

albert-github · albert-github · commit 36e0c205da26 · 2025-08-16T16:30:40.000+02:00
Remove redundant test on `DOT_NUM_THREADS`, the test on the maximum is already done when reading the value from the configuration file.
diff --git a/src/configimpl.l b/src/configimpl.l
@@ -2029,17 +2029,12 @@ void Config::checkAndCorrect(bool quiet, const bool check)
   }
 
   //------------------------
-  // clip number of threads
   int dotNumThreads = Config_getInt(DOT_NUM_THREADS);
-  if (dotNumThreads>512)
-  {
-    dotNumThreads=512;
-  }
-  else if (dotNumThreads<=0)
+  if (dotNumThreads<=0)
   {
     dotNumThreads=std::max(2u,std::thread::hardware_concurrency()+1);
+    Config_updateInt(DOT_NUM_THREADS,dotNumThreads);
   }
-  Config_updateInt(DOT_NUM_THREADS,dotNumThreads);
 
   //------------------------
   // check plantuml path

Original file line number	Diff line number	Diff line change
`@@ -2029,17 +2029,12 @@ void Config::checkAndCorrect(bool quiet, const bool check)`
`2029`	`2029`	`}`
`2030`	`2030`
`2031`	`2031`	`//------------------------`
`2032`		`- // clip number of threads`
`2033`	`2032`	`int dotNumThreads = Config_getInt(DOT_NUM_THREADS);`
`2034`		`- if (dotNumThreads>512)`
`2035`		`- {`
`2036`		`- dotNumThreads=512;`
`2037`		`- }`
`2038`		`- else if (dotNumThreads<=0)`
	`2033`	`+ if (dotNumThreads<=0)`
`2039`	`2034`	`{`
`2040`	`2035`	`dotNumThreads=std::max(2u,std::thread::hardware_concurrency()+1);`
	`2036`	`+ Config_updateInt(DOT_NUM_THREADS,dotNumThreads);`
`2041`	`2037`	`}`
`2042`		`- Config_updateInt(DOT_NUM_THREADS,dotNumThreads);`
`2043`	`2038`
`2044`	`2039`	`//------------------------`
`2045`	`2040`	`// check plantuml path`