Merge pull request doxygen#11813 from artyom-fedosov/fix/clang-tidy-warnings

Fix/clang-tidy-warnings

Author: doxygen

src/message.cpp

@@ -57,7 +57,6 @@ static void format_warn(const QCString &file,int line,const QCString &text)
 {
   QCString fileSubst = file.isEmpty() ? "<unknown>" : file;
   QCString lineSubst; lineSubst.setNum(line);
-  QCString textSubst = text;
   QCString versionSubst;
   // substitute markers by actual values
   QCString msgText =
@@ -72,7 +71,7 @@ static void format_warn(const QCString &file,int line,const QCString &text)
           ),
           "$version",versionSubst
         ),
-        "$text",textSubst
+        "$text",text
       );
   if (g_warnBehavior == WARN_AS_ERROR_t::YES)
   {

src/namespacedef.cpp

@@ -575,8 +575,7 @@ void NamespaceDefImpl::insertMember(MemberDef *md)
         }
         if (aliasMd)
         {
-          QCString name = md->name();
-          MemberName *mn = Doxygen::functionNameLinkedMap->add(name);
+          MemberName *mn = Doxygen::functionNameLinkedMap->add(md->name());
           mn->push_back(std::move(aliasMd));
         }
       }

src/pagedef.cpp

@@ -242,7 +242,7 @@ void PageDefImpl::writeDocumentation(OutputList &ol)
   PageDef *pd = this;
   while (pd->hasParentPage())
   {
-    pd = (PageDef *)pd->getOuterScope();
+    pd = dynamic_cast<PageDef *>(pd->getOuterScope());
     ++hierarchyLevel;
   }
 

src/searchindex_js.cpp

@@ -224,7 +224,7 @@ static void addMemberToSearchIndex(const MemberDef *md)
       )
      )
   {
-    QCString n = md->name();
+    const QCString &n = md->name();
     if (!n.isEmpty())
     {
       bool isFriendToHide = hideFriendCompounds &&
@@ -284,7 +284,7 @@ static void addMemberToSearchIndex(const MemberDef *md)
       )
      )
   {
-    QCString n = md->name();
+    const QCString &n = md->name();
     if (!n.isEmpty())
     {
       g_searchIndexInfo[SEARCH_INDEX_ALL].add(SearchTerm(n,md));

src/vhdldocgen.cpp

@@ -548,14 +548,13 @@ void VhdlDocGen::findAllArchitectures(std::vector<QCString>& qll,const ClassDef
 
 const ClassDef* VhdlDocGen::findArchitecture(const ClassDef *cd)
 {
-  QCString nn=cd->name();
   for (const auto &citer : *Doxygen::classLinkedMap)
   {
     QCString jj=citer->name();
     StringVector ql=split(jj.str(),":");
     if (ql.size()>1)
     {
-      if (ql[0]==nn)
+      if (ql[0]==cd->name())
       {
         return citer.get();
       }

src/vhdljjparser.cpp

@@ -88,8 +88,7 @@ struct VHDLOutlineParser::Private
 void VHDLOutlineParser::Private::parseVhdlfile(const QCString &fileName,
                                                const QCString &inputBuffer,bool inLine)
 {
-  QCString s =inputBuffer;
-  CharStream *stream = new CharStream(reinterpret_cast<const JJChar*>(s.data()), (int)s.size(), 1, 1);
+  CharStream *stream = new CharStream(reinterpret_cast<const JJChar*>(inputBuffer.data()), (int)inputBuffer.size(), 1, 1);
   VhdlParserTokenManager *tokenManager = new VhdlParserTokenManager(stream);
   VhdlTokenManagerErrorHandler *tokErrHandler=new VhdlTokenManagerErrorHandler(fileName.data());
   vhdlParser=new VhdlParser(tokenManager);
@@ -285,8 +284,7 @@ int VHDLOutlineParser::checkInlineCode(QCString &doc)
   {
     if ((int)str.length()<pos) return -1;
     reg::Match match;
-    const std::string s = str.str();
-    if (reg::search(s,match,re,pos)) // match found
+    if (reg::search(str.str(),match,re,pos)) // match found
     {
       return (int)match.position();
     }
@@ -522,15 +520,14 @@ void VHDLOutlineParser::addVhdlType(const QCString &n,int startLine,EntryType se
     VhdlSpecifier spec,const QCString &args,const QCString &type,Protection prot)
 {
   VhdlParser::SharedState *s = &p->shared;
-  QCString name(n);
   if (isFuncProcProced() || VhdlDocGen::getFlowMember())  return;
 
   if (s->parse_sec==VhdlSection::GEN_SEC)
   {
     spec=VhdlSpecifier::GENERIC;
   }
 
-  StringVector ql=split(name.str(),",");
+  StringVector ql=split(n.str(),",");
 
   for (size_t u=0;u<ql.size();u++)
   {
@@ -636,8 +633,7 @@ void VHDLOutlineParser::addProto(const QCString &s1,const QCString &s2,const QCS
 {
   VhdlParser::SharedState *s = &p->shared;
   (void)s5; // avoid unused warning
-  QCString name=s2;
-  StringVector ql=split(name.str(),",");
+  StringVector ql=split(s2.str(),",");
 
   for (const auto &n : ql)
   {