Correcting python scripts in respect to style

Based om the comment with the issue doxygen#11373, mentioning the `ruff` checker for python, adjusted the used python scripts where necessary and possible.

Author: albert-github

addon/doxmlparser/examples/metrics/metrics.py

@@ -36,8 +36,8 @@ def __init__(self):
     def print(self):
         numMethods    = self.numPubMethods    + self.numProMethods    + self.numPriMethods
         numDocMethods = self.numDocPubMethods + self.numDocProMethods + self.numDocPriMethods
-        print("Metrics:");
-        print("-----------------------------------");
+        print("Metrics:")
+        print("-----------------------------------")
         if self.numClasses>0:
             print("Classes:     {:=10} ({} documented)".format(self.numClasses,self.numDocClasses))
         if self.numStructs>0:
@@ -70,12 +70,12 @@ def print(self):
             print("Variables:   {:=10} ({} documented)".format(self.numVariables,self.numDocVariables))
         if self.numParams>0:
             print("Params:      {:=10}".format(self.numParams))
-        print("-----------------------------------");
+        print("-----------------------------------")
         if self.numClasses>0:
             print("Avg. #methods/compound:  {:=10}".format(float(numMethods)/float(self.numClasses)))
         if numMethods>0:
             print("Avg. #params/method:     {:=10}".format(float(self.numParams)/float(numMethods)))
-        print("-----------------------------------");
+        print("-----------------------------------")
 
 
 def description_is_empty(description):

addon/doxmlparser/generateDS_post.py

@@ -17,7 +17,6 @@
 def main():
     inputFile = open(sys.argv[1], 'r')
     outputFile = open(sys.argv[2], 'wb')
-    lineStr = ""
     for line in inputFile:
         line = line.rstrip()
         line = re.sub(r'##','# #',line)

addon/doxypysql/search.py

@@ -49,7 +49,7 @@ def re_fn(expr, item):
     return reg.search(item) is not None
 
 def openDb(dbname):
-    if dbname == None:
+    if dbname is None:
         dbname = "doxygen_sqlite3.db"
 
     if not os.path.isfile(dbname):
@@ -71,7 +71,7 @@ def match(self,row):
         if self.row_type is int:
             return " rowid=?"
         else:
-            if g_use_regexp == True:
+            if g_use_regexp:
                 return " REGEXP (?,%s)" %row
             else:
                 return " %s=?" %row
@@ -380,7 +380,7 @@ def serveCli(argv):
 
         cn=openDb(dbname)
         f=Finder(cn,o)
-        if ref != None:
+        if ref is not None:
             j=processHref(cn,ref)
         else:
             j=process(f,kind)

doc/translator.py

@@ -70,7 +70,6 @@
 from __future__ import print_function
 
 import os
-import platform
 import re
 import sys
 import textwrap
@@ -487,7 +486,7 @@ def __collectClassInfo(self, tokenIterator):
                     self.status = '0.0.00'
 
             # Check whether status was set, or set 'strange'.
-            if self.status == None:
+            if self.status is None:
                 self.status = 'strange'
             if not self.readableStatus:
                 self.readableStatus = 'strange'
@@ -765,7 +764,7 @@ def __collectPublicMethodPrototypes(self, tokenIterator):
         the source file."""
 
         assert(self.classId != 'Translator')
-        assert self.baseClassId != None, 'Class ' + self.classId + ' from the file ' + self.fname + ' does not have a base class.'
+        assert self.baseClassId is not None, 'Class ' + self.classId + ' from the file ' + self.fname + ' does not have a base class.'
 
         # The following finite automaton slightly differs from the one
         # inside self.collectPureVirtualPrototypes(). It produces the
@@ -782,7 +781,6 @@ def __collectPublicMethodPrototypes(self, tokenIterator):
         # identifiers.
         prototype = ''    # readable prototype (with everything)
         uniPrototype = '' # unified prototype (without arg. identifiers)
-        warning = ''      # warning message -- if something special detected
         methodId = None   # processed method id
 
         # Collect the method prototypes. Stop on the closing
@@ -1097,7 +1095,7 @@ def processing(self):
         # Eat the rest of the source to cause closing the file.
         while True:
             try:
-                t = next(tokenIterator)
+                next(tokenIterator)
             except StopIteration:
                 break
 
@@ -1414,7 +1412,8 @@ def __extractProcessedInfo(self):
         # of the list.
         langReadableLst = []
         for name, obj in self.langLst:
-            if obj.status == 'En': continue
+            if obj.status == 'En':
+                continue
 
             # Append the 'En' to the classId to possibly obtain the classId
             # of the English-based object. If the object exists, modify the
@@ -1665,7 +1664,8 @@ def generateTranslatorReport(self):
                 f.write('  %-6s' % obj.readableStatus)
                 numimpl = len(obj.missingMethods)
                 pluralS = ''
-                if numimpl > 1: pluralS = 's'
+                if numimpl > 1:
+                    pluralS = 's'
                 percent = 100 * numimpl / numRequired
                 f.write('\t%2d method%s to implement (%d %%)' % (
                         numimpl, pluralS, percent))
@@ -1693,7 +1693,8 @@ def generateTranslatorReport(self):
                 lst.sort()
                 plural = len(lst) > 1
                 note = 'Note: The adapter class'
-                if plural: note += 'es'
+                if plural:
+                    note += 'es'
                 note += ' ' + ', '.join(lst)
                 if not plural:
                     note += ' is'
@@ -1777,7 +1778,6 @@ def __loadMaintainers(self):
         inside = False  # inside the record for the language
         lineReady = True
         classId = None
-        maintainersLst = None
         self.__maintainersDic = {}
         while lineReady:
             line = f.readline()            # next line
@@ -1787,14 +1787,13 @@ def __loadMaintainers(self):
             if line != '' and line[0] == '%':    # skip the comment line
                 continue
 
-            if not inside:                 # if outside of the record
+            if not inside:                # if outside of the record
                 if line != '':            # should be language identifier
                     classId = line
-                    maintainersLst = []
                     inside = True
                 # Otherwise skip empty line that do not act as separator.
 
-            else:                          # if inside the record
+            else:                         # if inside the record
                 if line == '':            # separator found
                     inside = False
                 else:

doc_internal/cmds_tags.py

@@ -1,7 +1,9 @@
 #!/usr/bin/env python
 
 from __future__ import print_function
-import argparse, glob, itertools, re, shutil, os, sys
+import re
+import os
+import sys
 import subprocess
 import shlex
 
@@ -70,7 +72,7 @@ def get_commands(version):
         if cmds_reg.match(line):
             lst_list.append(re.sub(cmds_reg,'',line).replace("\\\\","\\"))
         elif line.startswith("\\endsecreflist"):
-            break;
+            break
     return lst_list
 
 
@@ -80,13 +82,13 @@ def process_commands(old_version,new_version):
     old_list = get_commands(old_version)
     new_list = get_commands(new_version)
     hits = []
-    for l in new_list:
+    for n in new_list:
         toadd = True
         for o in old_list:
-            if l == o:
+            if n == o:
                 toadd = False
         if toadd:
-            hits.append(l)
+            hits.append(n)
 
     cmds = ""
     first = True
@@ -121,21 +123,21 @@ def process_tags(old_version,new_version):
     (new_active,new_obsolete) = get_tags(new_version)
     hits_active = []
     hits_obsolete = []
-    for l in new_active:
+    for n in new_active:
         toadd = True
         for o in old_active:
-            if l == o:
+            if n == o:
                 toadd = False
         if toadd:
-            hits_active.append(l)
+            hits_active.append(n)
 
-    for l in new_obsolete:
+    for n in new_obsolete:
         toadd = True
         for o in old_obsolete:
-            if l == o:
+            if n == o:
                 toadd = False
         if toadd:
-            hits_obsolete.append(l)
+            hits_obsolete.append(n)
 
     tags= ""
     if len(hits_active) != 0:

src/caseconvert.py

@@ -45,32 +45,32 @@ def writePunctuationCodes(file):
 {
   switch(code)
   {
-''');
-writeMapping(file,toupper);
-file.write(r'''    default: return nullptr;
+''')
+writeMapping(file,toupper)
+file.write(r'''    default: return nullptr
   }
 }
 
 inline const char *convertUnicodeToLower(uint32_t code)
 {
   switch(code)
   {
-''');
-writeMapping(file,tolower);
-file.write(r'''    default: return nullptr;
+''')
+writeMapping(file,tolower)
+file.write(r'''    default: return nullptr
   }
 }
 
 inline bool isPunctuationCharacter(uint32_t code)
 {
   switch(code)
   {
-''');
-writePunctuationCodes(file);
-file.write(r'''    default: return false;
+''')
+writePunctuationCodes(file)
+file.write(r'''    default: return false
   }
-  return false;
+  return false
 }
 
 #endif
-''');
+''')