Potential memory leak

albert-github · albert-github · commit 637c7da36c23 · 2025-06-09T09:27:09.000+02:00
Fix potential (but very unlikely) memory leak as found by coverity.
diff --git a/deps/libmscgen/gd.c b/deps/libmscgen/gd.c
@@ -3208,11 +3208,11 @@ BGD_DECLARE(void) gdImageCopyResized (gdImagePtr dst, gdImagePtr src, int dstX,
 	}
 	/* Stretch vectors */
 	int *stx = (int *) gdMalloc (sizeof (int) * srcW);
-	int *sty = (int *) gdMalloc (sizeof (int) * srcH);
 	if (!stx) {
 		return;
 	}
 
+	int *sty = (int *) gdMalloc (sizeof (int) * srcH);
 	if (!sty) {
 		gdFree(stx);
 		return;

Original file line number	Diff line number	Diff line change
`@@ -3208,11 +3208,11 @@ BGD_DECLARE(void) gdImageCopyResized (gdImagePtr dst, gdImagePtr src, int dstX,`
`3208`	`3208`	`}`
`3209`	`3209`	`/* Stretch vectors */`
`3210`	`3210`	`int stx = (int ) gdMalloc (sizeof (int) * srcW);`
`3211`		`- int sty = (int ) gdMalloc (sizeof (int) * srcH);`
`3212`	`3211`	`if (!stx) {`
`3213`	`3212`	`return;`
`3214`	`3213`	`}`
`3215`	`3214`
	`3215`	`+ int sty = (int ) gdMalloc (sizeof (int) * srcH);`
`3216`	`3216`	`if (!sty) {`
`3217`	`3217`	`gdFree(stx);`
`3218`	`3218`	`return;`