issue doxygen#11374 c++ template function definition miss-ref

Author: doxygen

src/doxygen.cpp

@@ -4019,15 +4019,12 @@ static void buildFunctionList(const Entry *root)
 
               // in case of template functions, we need to check if the
               // functions have the same number of template parameters
-              bool sameNumTemplateArgs = TRUE;
+              bool sameTemplateArgs = TRUE;
               bool matchingReturnTypes = TRUE;
               bool sameRequiresClause = TRUE;
               if (!mdTempl.empty() && !root->tArgLists.empty())
               {
-                if (mdTempl.size()!=root->tArgLists.back().size())
-                {
-                  sameNumTemplateArgs = FALSE;
-                }
+                sameTemplateArgs = matchTemplateArguments(mdTempl,root->tArgLists.back());
                 if (md->typeString()!=removeRedundantWhiteSpace(root->type))
                 {
                   matchingReturnTypes = FALSE;
@@ -4040,7 +4037,7 @@ static void buildFunctionList(const Entry *root)
               else if (!mdTempl.empty() || !root->tArgLists.empty())
               { // if one has template parameters and the other doesn't then that also counts as a
                 // difference
-                sameNumTemplateArgs = FALSE;
+                sameTemplateArgs = FALSE;
               }
 
               bool staticsInDifferentFiles =
@@ -4050,7 +4047,7 @@ static void buildFunctionList(const Entry *root)
                   matchArguments2(md->getOuterScope(),mfd,&mdAl,
                     rnd ? rnd : Doxygen::globalScope,rfd,&root->argList,
                     FALSE,root->lang) &&
-                  sameNumTemplateArgs &&
+                  sameTemplateArgs &&
                   matchingReturnTypes &&
                   sameRequiresClause &&
                   !staticsInDifferentFiles

src/util.cpp

@@ -2193,6 +2193,39 @@ void mergeArguments(ArgumentList &srcAl,ArgumentList &dstAl,bool forceNameOverwr
 
 //---------------------------------------------------------------------------------------
 
+bool matchTemplateArguments(const ArgumentList &srcAl,const ArgumentList &dstAl)
+{
+  AUTO_TRACE("srcAl=%s dstAl=%s",argListToString(srcAl),argListToString(dstAl));
+  if (srcAl.size()!=dstAl.size()) // different number of template parameters -> overload
+  {
+    AUTO_TRACE_EXIT("different number of parameters");
+    return false;
+  }
+  auto isUnconstraintTemplate = [](const QCString &type)
+  {
+    return type=="typename" || type=="class" || type.startsWith("typename ") || type.startsWith("class ");
+  };
+  auto srcIt = srcAl.begin();
+  auto dstIt = dstAl.begin();
+  while (srcIt!=srcAl.end() && dstIt!=dstAl.end())
+  {
+    const Argument &srcA = *srcIt;
+    const Argument &dstA = *dstIt;
+    if ((!isUnconstraintTemplate(srcA.type) || !isUnconstraintTemplate(dstA.type)) && srcA.type!=dstA.type) // different constraints -> overload
+    {
+      AUTO_TRACE_EXIT("different constraints");
+      return false;
+    }
+    ++srcIt;
+    ++dstIt;
+  }
+  AUTO_TRACE_EXIT("same");
+  // no overload with respect to the template parameters
+  return true;
+}
+
+//---------------------------------------------------------------------------------------
+
 static void findMembersWithSpecificName(const MemberName *mn,
                                         const QCString &args,
                                         bool checkStatics,

src/util.h

@@ -169,6 +169,8 @@ bool matchArguments2(const Definition *srcScope,const FileDef *srcFileScope,cons
 
 void mergeArguments(ArgumentList &,ArgumentList &,bool forceNameOverwrite=FALSE);
 
+bool matchTemplateArguments(const ArgumentList &srcAl,const ArgumentList &dstAl);
+
 QCString substituteClassNames(const QCString &s);
 
 struct SelectionBlock