[mscgen] Make variables more local

Move declaration of variable into for loop header.
Move declaration closer to variable use.
Unify declaration and initialization.

Many found by Cppcheck (variableScope).

Author: gruenich