Agg builder blog post #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Oct 23, 2024
tests/AggregationBlogPost/article.md
Outdated
Comment on lines
710
to
713
| the builder and feel what it's like. To top it all off, we could add this code | ||
| to the server documentation, similar to how we add other language-specific code | ||
| snippets. We're not quite there yet, but we'd love to include this in the | ||
| documentation. |
There was a problem hiding this comment.
Ultimately, we love to add this builder code to the server documentation, similar to how we add other language-specific code snippets, but we're not quite there yet.
See if that reads better. I don't think this idea warrants more than a single sentence.
Co-authored-by: Jeremy Mikola <[email protected]>
jmikola
approved these changes
Oct 24, 2024
jmikola
left a comment
jmikola
left a comment
There was a problem hiding this comment.
A few more optional suggestions. Take what you like.
| underscore would break alphabetical sorting in code completion. | ||
|
|
||
| A less-than-serious approach was to use emojis, which I learned was valid in | ||
| PHP: |
There was a problem hiding this comment.
If you want to be especially evil: https://en.wikipedia.org/wiki/Zero-width_space
Co-authored-by: Jeremy Mikola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ignore the test files - only article.md needs review.