feat: add delete: false support to DnsRecords resource#1360
Merged
Mkassabov merged 3 commits intoalchemy-run:mainfrom Mar 13, 2026
Merged
feat: add delete: false support to DnsRecords resource#1360Mkassabov merged 3 commits intoalchemy-run:mainfrom
Mkassabov merged 3 commits intoalchemy-run:mainfrom
Conversation
Adds a `delete` property to DnsRecordsProps that prevents DNS records from being deleted when the resource is destroyed or when records are removed from the records array during updates. This follows the same pattern used by Zone, D1Database, Bucket, and 15+ other resources.
commit: |
sam-goodwin
approved these changes
Mar 13, 2026
sam-goodwin
reviewed
Mar 13, 2026
| } | ||
| }); | ||
|
|
||
| test("delete: false preserves records on destroy", async (scope) => { |
Collaborator
There was a problem hiding this comment.
: is not allowed in test names, please remove the :
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
deleteproperty to DnsRecordsProps that prevents DNS records from being deleted when the resource is destroyed or when records are removed from the records array during updates. This follows the same pattern used by Zone, D1Database, Bucket, and 15+ other resources.