Apply suggestions from code review

Author: mulimoen

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Unreleased
 
 ### Added
+
 - Conversion from `Infallible` to `Error` to allow infallible conversion to
   extents.
 

examples/chunking.rs

@@ -1,37 +1,37 @@
 //! Create, write, and read a chunked dataset
-fn main() -> hdf5::Result<()> {
-    let file = hdf5::File::create("chunking.h5")?;
 
-    let ny = 100;
-    let nx = 100;
-    let arr = ndarray::Array2::from_shape_fn((ny, nx), |(j, i)| (1000 * j + i) as f32);
+use hdf5::{File, Result};
+use ndarray::Array2;
 
-    {
-        let ds = file
+fn main() -> Result<()> {
+    let file = File::create("chunking.h5")?;
+
+    let (ny, nx) = (100, 100);
+    let arr = Array2::from_shape_fn((ny, nx), |(j, i)| (1000 * j + i) as f32);
+
+    let ds = file
         .new_dataset::<f32>()
-        .chunk((1, ny, nx))  // nx*ny elements will be compressed as a single chunk
-        .shape((1.., ny, nx)) // Initial size of 1 on the unlimited dimension
+        .chunk((1, ny, nx))  // each chunk contains ny * nx elements
+        .shape((1.., ny, nx)) // first axis is unlimited with initial size of 1
         .deflate(3)
         .create("variable")?;
 
-        // Writing a chunk at a time will be most efficient
-        ds.write_slice(&arr, (0, .., ..))?;
+    // writing one chunk at a time is the most efficient
+    ds.write_slice(&arr, (0, .., ..))?;
 
-        // Dataset can be resized along an unlimited dimension
-        ds.resize((10, ny, nx))?;
-        ds.write_slice(&arr, (1, .., ..))?;
-    }
+    // dataset can be resized along an unlimited dimension
+    ds.resize((10, ny, nx))?;
+    ds.write_slice(&arr, (1, .., ..))?;
 
-    let ds = file.dataset("variable")?;
     let chunksize = ds.chunk().unwrap();
     assert_eq!(chunksize, &[1, ny, nx]);
 
     let shape = ds.shape();
     assert_eq!(shape, &[10, ny, nx]);
 
-    // Reading from a chunked dataset should be done in a chunk-wise order
+    // it's best to read from a chunked dataset in a chunk-wise fashion
     for k in 0..shape[0] {
-        let _arr: ndarray::Array2<f32> = ds.read_slice((k, .., ..))?;
+        let _arr: Array2<f32> = ds.read_slice((k, .., ..))?;
     }
 
     Ok(())

src/error.rs

@@ -1,3 +1,4 @@
+use std::convert::Infallible;
 use std::error::Error as StdError;
 use std::fmt;
 use std::ops::Deref;
@@ -229,8 +230,8 @@ impl From<String> for Error {
     }
 }
 
-impl From<core::convert::Infallible> for Error {
-    fn from(_v: core::convert::Infallible) -> Self {
+impl From<Infallible> for Error {
+    fn from(_: Infallible) -> Self {
         unreachable!("Infallible error can never be constructed")
     }
 }