Minor clippy lints

Author: mulimoen

hdf5-src/build.rs

@@ -41,7 +41,7 @@ fn main() {
         let zlib_lib = "z";
         cfg.define("HDF5_ENABLE_Z_LIB_SUPPORT", "ON")
             .define("H5_ZLIB_HEADER", &zlib_header)
-            .define("ZLIB_STATIC_LIBRARY", &zlib_lib);
+            .define("ZLIB_STATIC_LIBRARY", zlib_lib);
         println!("cargo:zlib_header={}", zlib_header.to_str().unwrap());
         println!("cargo:zlib={}", zlib_lib);
     }

hdf5-sys/build.rs

@@ -565,7 +565,7 @@ impl LibrarySearcher {
                     }
                 }
             }
-            let header = Header::parse(&inc_dir);
+            let header = Header::parse(inc_dir);
             if let Some(version) = self.version {
                 assert_eq!(header.version, version, "HDF5 header version mismatch",);
             }

src/hl/file.rs

@@ -50,7 +50,7 @@ impl ObjectClass for File {
     fn short_repr(&self) -> Option<String> {
         let basename = match Path::new(&self.filename()).file_name() {
             Some(s) => s.to_string_lossy().into_owned(),
-            None => "".to_owned(),
+            None => String::new(),
         };
         let mode = if self.is_read_only() { "read-only" } else { "read/write" };
         Some(format!("\"{}\" ({})", basename, mode))

src/hl/location.rs

@@ -70,13 +70,13 @@ impl Location {
     /// have a name (e.g., an anonymous dataset).
     pub fn name(&self) -> String {
         // TODO: should this return Result<String> or an empty string if it fails?
-        h5lock!(get_h5_str(|m, s| H5Iget_name(self.id(), m, s)).unwrap_or_else(|_| "".to_string()))
+        h5lock!(get_h5_str(|m, s| H5Iget_name(self.id(), m, s)).unwrap_or_else(|_| String::new()))
     }
 
     /// Returns the name of the file containing the named object (or the file itself).
     pub fn filename(&self) -> String {
         // TODO: should this return Result<String> or an empty string if it fails?
-        h5lock!(get_h5_str(|m, s| H5Fget_name(self.id(), m, s)).unwrap_or_else(|_| "".to_string()))
+        h5lock!(get_h5_str(|m, s| H5Fget_name(self.id(), m, s)).unwrap_or_else(|_| String::new()))
     }
 
     /// Returns a handle to the file containing the named object (or the file itself).

src/hl/plist/dataset_access.rs

@@ -271,7 +271,7 @@ impl DatasetAccess {
 
     #[cfg(feature = "1.8.17")]
     pub fn efile_prefix(&self) -> String {
-        self.get_efile_prefix().ok().unwrap_or_else(|| "".into())
+        self.get_efile_prefix().ok().unwrap_or_default()
     }
 
     #[cfg(feature = "1.10.0")]

src/hl/plist/file_access.rs

@@ -702,7 +702,7 @@ impl Default for MetadataCacheConfig {
             rpt_fcn_enabled: false,
             open_trace_file: false,
             close_trace_file: false,
-            trace_file_name: "".into(),
+            trace_file_name: String::new(),
             evictions_enabled: true,
             set_initial_size: true,
             initial_size: 1 << 21,
@@ -857,20 +857,13 @@ mod cache_image_config {
 pub use self::cache_image_config::*;
 
 #[cfg(feature = "1.10.0")]
-#[derive(Clone, Debug, PartialEq, Eq)]
+#[derive(Clone, Debug, Default, PartialEq, Eq)]
 pub struct CacheLogOptions {
     pub is_enabled: bool,
     pub location: String,
     pub start_on_access: bool,
 }
 
-#[cfg(feature = "1.10.0")]
-impl Default for CacheLogOptions {
-    fn default() -> Self {
-        Self { is_enabled: false, location: "".into(), start_on_access: false }
-    }
-}
-
 #[cfg(feature = "1.10.2")]
 mod libver {
     use super::*;

src/util.rs

@@ -63,7 +63,7 @@ where
     let len = 1_isize + (func(ptr::null_mut(), 0)).try_into().unwrap_or(-1);
     ensure!(len > 0, "negative string length in get_h5_str()");
     if len == 1 {
-        Ok("".to_owned())
+        Ok(String::new())
     } else {
         let mut buf = vec![0; len as usize];
         func(buf.as_mut_ptr(), len as _);