-
Notifications
You must be signed in to change notification settings - Fork 12
Description
I was using the get_all_ivs() and noticed a couple of minor items that could be cleaned up or improved:
-
The data aggregation arguments available in
get_iv()are not available inget_all_ivs(). Could modifyget_all_ivs()to accept all arguments accepted byget_iv()(specifically sample_period, and agg_method). -
Discharge parameter and units are hard coded in
get_ivs(), and are included in the returned DataFrame even when a user pulls gw level data. One fix would be to add a parameter code/info dictionary tonwis.selfto use in the method so that the appropriate units are added to the data column to the returned DataFrame. -
Might consider adding a few additional parameter types to
self.parameter_codes, specifically: 62611 (Elevation, GW, NAVD88) and 00065 (Gage height, feet).