Licensing conflict

[MestreLion]

Hi Alessandro! First of all, congrats for your icons! They are amazing!

I've noticed a small, but perhaps significant, conflict in licensing terms: you're using CC-BY-SA 4.0, which allows commercial use, but the repository README explicitly says "the iconset is free to use as long as its use is _not_ conveying any monetary income" (your emphasis).

This conflict could prevent your work to be packaged and accepted in Debian and other distros (or hosted in Ubuntu's Launchpad as a PPA). It could also prevent developers to integrate them in free software licensed with GPL, BSD, MIT or even the same CC-BY-SA license you're using.

To solve the conflict, you could either change the license to the non-commercial Creative Commons BY-NC-SA, to make it compatible with your README disclaimer (but note that is not a free license, so I truly hope you don't do that), _or_ to delete that line from your README to make it compatible with you current license (yes, yes! 👍)

[MestreLion]

Disclaimer: I'm planning to use one of your icons, apps/game-cards, in a silly Solitaire-like game I'm creating for family and friends. Although I have no plans for commercial use of my game, I would gladly share with you if I ever get a penny out of it (which is extremely unlikely... well, daddy might buy me a beer)

As for Attribuition, I've created a README for your icons, fully crediting you and FlatWoken, along with all relevant links. You may take a look and see if this is fine: https://github.com/MestreLion/pylitaire/tree/master/data/icons

[staniek]

Exact same opinion here @MestreLion. You have not picked the BY-NC-SA, and now it's too late, so changing the README would be a good move (also at PR level). Kudos for your hard work, I know what it takes to deliver so large quality content!

[alecive]

Sorry for the super late reply. I don't really care about licensing terms and so on (as you might have understood), and over the time I forgot to answer to this issue.
@MestreLion as far as your app is concerned, I think that I waited so long that you even deleted it from your account, isn't it? Regardless, I am going to accept your pr.
@MestreLion @staniek any other contribution in this regard would be more than welcome. I am only trying to protect my (hard) work from misbehaving individualities (it happened more than once in the past with other projects), but I do not really know how is it better to proceed. Regrettably, it is way more difficult to license design work rather than software.

[staniek]

@alecive thanks!

[MestreLion]

@alecive they were not deleted, I just moved the code (and artwork) to a package. New path is https://github.com/MestreLion/pylitaire/tree/master/pylitaire/data/icons

I see now that you incorporated my suggestions to the README.md, thanks! I was afraid you wouldn't after the changes in commit 374ec08 (which was made 2 days after I post this bug, what coincidence!).

But I'm very happy to see commit b52f0f7 👍

Thank you very much! You ma close this bug as well, as I think conflicts were solved and there's no ambiguity in the terms now :)