Skip to content

Commit b787e3d

Browse files
authored
experimental: Fix chrome 134 regression bug (webstudio-is#5046)
## Description https://issues.chromium.org/issues/403708813 ## Steps for reproduction Type in Debug Console `ScrollTimeline` for Chrome 134.0.6998.164 >= version >= 134.0.6998.0 This would be non native code ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 0000) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env` file
1 parent ccba8d9 commit b787e3d

File tree

4 files changed

+10
-4
lines changed

4 files changed

+10
-4
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ jobs:
135135
const results = [
136136
await assertSize('./fixtures/ssg/dist/client', 352),
137137
await assertSize('./fixtures/react-router-netlify/build/client', 368),
138-
await assertSize('./fixtures/webstudio-features/build/client', 1024),
138+
await assertSize('./fixtures/webstudio-features/build/client', 1028),
139139
]
140140
for (const result of results) {
141141
if (result.passed) {

@types/navigator.d.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
interface Navigator {
2-
userAgentData?: { brands: Array<{ brand: string; version: string }> };
2+
userAgentData?: {
3+
brands: Array<{ brand: string; version: string }>;
4+
getHighEntropyValues(hints: string[]): Promise<{
5+
fullVersionList?: Array<{ brand: string; version: string }>;
6+
}>;
7+
};
38
}

packages/sdk-components-animation/tsconfig.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
"src",
55
"../../@types/**/scroll-timeline.d.ts",
66
"private-src",
7-
"../sdk/src/schema/animation-schema.ts"
7+
"../sdk/src/schema/animation-schema.ts",
8+
"../../@types/navigator.d.ts"
89
],
910
"exclude": ["private-src/perf/**/*"],
1011
"compilerOptions": {

0 commit comments

Comments
 (0)