chore: a couple of tweaks

Author: alecthomas

.github/workflows/default-ci.yaml

@@ -2,9 +2,9 @@ name: CMake Build
 
 on:
   push:
-    branches: [ master ]
+    branches: [master]
   pull_request:
-    branches: [ master ]
+    branches: [master]
 
 jobs:
   build:
@@ -15,24 +15,24 @@ jobs:
         build_type: [Release, Debug]
         shared_library: [True, False]
         exclude:
-        # Building a shared library is currently unsupported on Windows.
-        - os: windows-latest
-          shared_library: True
+          # Building a shared library is currently unsupported on Windows.
+          - os: windows-latest
+            shared_library: True
 
     steps:
-    - uses: actions/checkout@v2
+      - uses: actions/checkout@v2
 
-    - name: Configure CMake
-      # Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required when using a single-configuration generator such as make.
-      # See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type
-      run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{matrix.build_type}} -DENTITYX_BUILD_SHARED=${{matrix.shared_library}}
+      - name: Configure CMake
+        # Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required when using a single-configuration generator such as make.
+        # See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type
+        run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{matrix.build_type}} -DENTITYX_BUILD_SHARED=${{matrix.shared_library}}
 
-    - name: Build
-      # Build the library with the given configuration
-      run: cmake --build ${{github.workspace}}/build --config ${{matrix.build_type}}
+      - name: Build
+        # Build the library with the given configuration
+        run: cmake --build ${{github.workspace}}/build --config ${{matrix.build_type}}
 
-    - name: Test
-      working-directory: ${{github.workspace}}/build
-      # Execute tests defined by the CMake configuration.
-      # See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail
-      run: ctest -C ${{matrix.build_type}}
+      - name: Test
+        working-directory: ${{github.workspace}}/build
+        # Execute tests defined by the CMake configuration.
+        # See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail
+        run: ctest -C ${{matrix.build_type}} --output-on-failure

.gitignore

@@ -8,3 +8,15 @@ Makefile
 html/
 Vagrantfile
 .vagrant
+CMakeLists.txt.user
+CMakeCache.txt
+CMakeFiles
+CMakeScripts
+Testing
+Makefile
+cmake_install.cmake
+install_manifest.txt
+compile_commands.json
+CTestTestfile.cmake
+_deps
+CMakeUserPresets.json

CMakeLists.txt

@@ -86,7 +86,7 @@ endif ()
 
 
 # Misc features
-check_include_file("stdint.h" HAVE_STDINT_H)
+check_include_file("cstdint" HAVE_STDINT_H)
 
 macro(require FEATURE_NAME MESSAGE_STRING)
     if (NOT ${${FEATURE_NAME}})
@@ -121,7 +121,7 @@ if (NOT CMAKE_BUILD_TYPE)
 endif()
 
 message(STATUS "-- Checking misc features")
-require(HAVE_STDINT_H "stdint.h")
+require(HAVE_STDINT_H "cstdint")
 
 # Things to install
 
@@ -146,7 +146,7 @@ if (ENTITYX_BUILD_SHARED)
           $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>)
 else()
     add_library(entityx STATIC ${sources})
-    set_target_properties(entityx PROPERTIES 
+    set_target_properties(entityx PROPERTIES
         DEBUG_POSTFIX "${CMAKE_DEBUG_POSTFIX}"
         FOLDER entityx)
     set(install_libs entityx)

entityx/help/Pool_test.cc

@@ -10,7 +10,6 @@
 
 #define CATCH_CONFIG_MAIN
 
-#include <vector>
 #include "entityx/3rdparty/catch.hpp"
 #include "entityx/help/Pool.h"