Review feedback 1

alelenv · alelenv · commit cc41e69c4522 · 2025-01-29T08:24:34.000-08:00
a. Remove multiple capabilities
b. Add implicitly enable capability
diff --git a/include/spirv/unified1/spirv.core.grammar.json b/include/spirv/unified1/spirv.core.grammar.json
@@ -6219,7 +6219,7 @@
               "name" : "'Intersection'"
           }
       ],
-      "capabilities" : [ "RayQueryKHR", "RayTracingClusterAccelerationStructureNV" ],
+      "capabilities" : [ "RayTracingClusterAccelerationStructureNV" ],
       "version" : "None"
     },
     {
@@ -6231,7 +6231,7 @@
           { "kind" : "IdResult" },
           { "kind" : "IdRef", "name" : "'Hit Object'" }
       ],
-      "capabilities" : [ "ShaderInvocationReorderNV" , "RayTracingClusterAccelerationStructureNV" ],
+      "capabilities" : [ "RayTracingClusterAccelerationStructureNV" ],
       "version" : "None"
     },
     {
@@ -16311,6 +16311,7 @@
         {
           "enumerant" : "RayTracingClusterAccelerationStructureNV",
           "value" : 5437,
+          "capabilities" : [ "RayTracingKHR" ],
           "extensions" : [ "SPV_NV_cluster_acceleration_structure" ],
           "version" : "None"
         },

Original file line number	Diff line number	Diff line change
`@@ -6219,7 +6219,7 @@`
`6219`	`6219`	`"name" : "'Intersection'"`
`6220`	`6220`	`}`
`6221`	`6221`	`],`
`6222`		`- "capabilities" : [ "RayQueryKHR", "RayTracingClusterAccelerationStructureNV" ],`
	`6222`	`+ "capabilities" : [ "RayTracingClusterAccelerationStructureNV" ],`
`6223`	`6223`	`"version" : "None"`
`6224`	`6224`	`},`
`6225`	`6225`	`{`
`@@ -6231,7 +6231,7 @@`
`6231`	`6231`	`{ "kind" : "IdResult" },`
`6232`	`6232`	`{ "kind" : "IdRef", "name" : "'Hit Object'" }`
`6233`	`6233`	`],`
`6234`		`- "capabilities" : [ "ShaderInvocationReorderNV" , "RayTracingClusterAccelerationStructureNV" ],`
	`6234`	`+ "capabilities" : [ "RayTracingClusterAccelerationStructureNV" ],`
`6235`	`6235`	`"version" : "None"`
`6236`	`6236`	`},`
`6237`	`6237`	`{`
`@@ -16311,6 +16311,7 @@`
`16311`	`16311`	`{`
`16312`	`16312`	`"enumerant" : "RayTracingClusterAccelerationStructureNV",`
`16313`	`16313`	`"value" : 5437,`
	`16314`	`+ "capabilities" : [ "RayTracingKHR" ],`
`16314`	`16315`	`"extensions" : [ "SPV_NV_cluster_acceleration_structure" ],`
`16315`	`16316`	`"version" : "None"`
`16316`	`16317`	`},`