Added an API to factorise CustomPortBehavior by type

Author: alelievr

Assets/com.alelievr.NodeGraphProcessor/Runtime/Elements/BaseNode.cs

@@ -9,6 +9,7 @@
 namespace GraphProcessor
 {
 	public delegate IEnumerable< PortData > CustomPortBehaviorDelegate(List< SerializableEdge > edges);
+	public delegate IEnumerable< PortData > CustomPortTypeBehaviorDelegate(string fieldName, string displayName, object value);
 
 	[Serializable]
 	public abstract class BaseNode
@@ -105,6 +106,9 @@ public abstract class BaseNode
 		[NonSerialized]
 		internal Dictionary< string, NodeFieldInformation >	nodeFields = new Dictionary< string, NodeFieldInformation >();
 
+		[NonSerialized]
+		internal Dictionary< Type, CustomPortTypeBehaviorDelegate> customPortTypeBehaviorMap = new Dictionary<Type, CustomPortTypeBehaviorDelegate>();
+
 		[NonSerialized]
 		List< string >				messages = new List< string >();
 
@@ -186,12 +190,53 @@ public static BaseNode CreateFromType(Type nodeType, Vector2 position)
 		public void Initialize(BaseGraph graph)
 		{
 			this.graph = graph;
+			InitializeCustomPortTypeMethods();
 
 			ExceptionToLog.Call(() => Enable());
 
 			InitializePorts();
 		}
 
+		void InitializeCustomPortTypeMethods()
+		{
+			// var methods = GetType().GetMethods(BindingFlags.Instance | BindingFlags.Static | BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.FlattenHierarchy);
+
+			// if (GetType().Name.Contains("Distance"))
+			// 	Debug.Log(GetType().GetMethod("GetTypeFromTextureDim", BindingFlags.Instance | BindingFlags.NonPublic | BindingFlags.FlattenHierarchy));
+
+			MethodInfo[] methods = new MethodInfo[0];
+			Type baseType = GetType();
+			while (true)
+			{
+				methods = baseType.GetMethods(BindingFlags.NonPublic | BindingFlags.Instance);
+				foreach (var method in methods)
+				{
+					var typeBehaviors = method.GetCustomAttributes<CustomPortTypeBehavior>().ToArray();
+
+					if (typeBehaviors.Length == 0)
+						continue;
+
+					CustomPortTypeBehaviorDelegate deleg = null;
+					try
+					{
+						deleg = Delegate.CreateDelegate(typeof(CustomPortTypeBehaviorDelegate), this, method) as CustomPortTypeBehaviorDelegate;
+					} catch (Exception e)
+					{
+						Debug.LogError(e);
+						Debug.LogError($"Cannot convert method {method} to a delegate of type {typeof(CustomPortTypeBehaviorDelegate)}");
+					}
+
+					foreach (var typeBehavior in typeBehaviors)
+						customPortTypeBehaviorMap[typeBehavior.type] = deleg;
+				}
+
+				// Try to also find private methods in the base class
+				baseType = baseType.BaseType;
+				if (baseType == null)
+					break;
+			}
+		}
+
 		/// <summary>
 		/// Use this function to initialize anything related to ports generation in your node
 		/// This will allow the node creation menu to correctly recognize ports that can be connected between nodes
@@ -202,7 +247,7 @@ public virtual void InitializePorts()
 			{
 				var nodeField = nodeFieldKP.Value;
 
-				if (nodeField.behavior != null)
+				if (HasCustomBehavior(nodeField))
 				{
 					UpdatePortsForField(nodeField.fieldName);
 				}
@@ -262,7 +307,7 @@ public bool UpdatePortsForFieldLocal(string fieldName)
 
 			var fieldInfo = nodeFields[fieldName];
 
-			if (fieldInfo.behavior == null)
+			if (!HasCustomBehavior(fieldInfo))
 				return false;
 
 			List< string > finalPorts = new List< string >();
@@ -274,7 +319,20 @@ public bool UpdatePortsForFieldLocal(string fieldName)
 			// Gather all edges connected to these fields:
 			var edges = nodePorts.SelectMany(n => n.GetEdges()).ToList();
 
-			foreach (var portData in fieldInfo.behavior(edges))
+			if (fieldInfo.behavior != null)
+			{
+				foreach (var portData in fieldInfo.behavior(edges))
+					AddPortData(portData);
+			}
+			else
+			{
+				var customPortTypeBehavior = customPortTypeBehaviorMap[fieldInfo.info.FieldType];
+
+				foreach (var portData in customPortTypeBehavior(fieldName, fieldInfo.name, fieldInfo.info.GetValue(this)))
+					AddPortData(portData);
+			}
+
+			void AddPortData(PortData portData)
 			{
 				var port = nodePorts.FirstOrDefault(n => n.portData.identifier == portData.identifier);
 				// Guard using the port identifier so we don't duplicate identifiers
@@ -335,6 +393,17 @@ public bool UpdatePortsForFieldLocal(string fieldName)
 			return changed;
 		}
 
+		bool HasCustomBehavior(NodeFieldInformation info)
+		{
+			if (info.behavior != null)
+				return true;
+
+			if (customPortTypeBehaviorMap.ContainsKey(info.info.FieldType))
+				return true;
+			
+			return false;
+		}
+
 		/// <summary>
 		/// Update the ports related to one C# property field and all connected nodes in the graph
 		/// </summary>
@@ -372,7 +441,7 @@ public bool UpdatePortsForField(string fieldName)
 							foreach(var edge in port.GetEdges())
 							{
 								var edgeNode = (node.IsFieldInput(field)) ? edge.outputNode : edge.inputNode;
-								var fieldsWithBehavior = edgeNode.nodeFields.Values.Where(f => f.behavior != null).Select(f => f.fieldName).ToList();
+								var fieldsWithBehavior = edgeNode.nodeFields.Values.Where(f => HasCustomBehavior(f)).Select(f => f.fieldName).ToList();
 								fieldsToUpdate.Push(new PortUpdate{fieldNames = fieldsWithBehavior, node = edgeNode});
 							}
 						}

Assets/com.alelievr.NodeGraphProcessor/Runtime/Graph/Attributes.cs

@@ -157,6 +157,23 @@ public CustomPortBehaviorAttribute(string fieldName)
 		}
 	}
 
+	/// <summary>
+	/// Allow to bind a method to generate a specific set of ports based on a field type in a node
+	/// </summary>
+	[AttributeUsage(AttributeTargets.Method, AllowMultiple = true)]
+	public class CustomPortTypeBehavior : Attribute
+	{
+		/// <summary>
+		/// Target type
+		/// </summary>
+		public Type type;
+
+		public CustomPortTypeBehavior(Type type)
+		{
+			this.type = type;
+		}
+	}
+
 	/// <summary>
 	/// Allow you to have a custom view for your stack nodes
 	/// </summary>