Merge pull request #109 from gelonsoft/customize-edgeview

New feature - PortView and EdgeView customization, removed hardcoded instance creation

Author: alelievr

Assets/com.alelievr.NodeGraphProcessor/Editor/Utils/BaseEdgeConnector.cs

@@ -9,19 +9,24 @@ namespace GraphProcessor
 {
 	public class BaseEdgeConnector : EdgeConnector
 	{
-		BaseEdgeDragHelper dragHelper;
+		protected BaseEdgeDragHelper dragHelper;
         Edge edgeCandidate;
-        private bool active;
+        protected bool active;
         Vector2 mouseDownPosition;
 
         internal const float k_ConnectionDistanceTreshold = 10f;
 
 		public BaseEdgeConnector(IEdgeConnectorListener listener) : base()
 		{
-            dragHelper = new BaseEdgeDragHelper(listener);
             active = false;
+            initEdgeConnector(listener);
+        }
+
+        protected virtual void initEdgeConnector(IEdgeConnectorListener listener)
+        {
+            dragHelper = new BaseEdgeDragHelper(listener);
             activators.Add(new ManipulatorActivationFilter { button = MouseButton.LeftMouse });
-		}
+        }
 
 		public override EdgeDragHelper edgeDragHelper => dragHelper;
 
@@ -63,7 +68,7 @@ protected virtual void OnMouseDown(MouseDownEvent e)
 
             mouseDownPosition = e.localMousePosition;
 
-            edgeCandidate = new EdgeView();
+            edgeCandidate = CreateEdgeView();
             edgeDragHelper.draggedPort = graphElement;
             edgeDragHelper.edgeCandidate = edgeCandidate;
 
@@ -81,6 +86,11 @@ protected virtual void OnMouseDown(MouseDownEvent e)
             }
         }
 
+        protected virtual EdgeView CreateEdgeView()
+        {
+            return new EdgeView();
+        }
+
         void OnCaptureOut(MouseCaptureOutEvent e)
         {
             active = false;

Assets/com.alelievr.NodeGraphProcessor/Editor/Utils/BaseEdgeDragHelper.cs

@@ -218,7 +218,7 @@ public override void HandleMouseMove(MouseMoveEvent evt)
             {
                 if (ghostEdge == null)
                 {
-                    ghostEdge = new EdgeView();
+                    ghostEdge = CreateEdgeView();
                     ghostEdge.isGhostEdge = true;
                     ghostEdge.pickingMode = PickingMode.Ignore;
                     graphView.AddElement(ghostEdge);
@@ -260,6 +260,11 @@ public override void HandleMouseMove(MouseMoveEvent evt)
             }
         }
 
+        protected virtual EdgeView CreateEdgeView()
+        {
+            return new EdgeView();
+        }
+
         private void Pan(TimerState ts)
         {
             graphView.viewTransform.position -= panDiff;

Assets/com.alelievr.NodeGraphProcessor/Editor/Views/BaseGraphView.cs

@@ -289,19 +289,22 @@ void UnserializeAndPasteCallback(string operationName, string serializedData)
 
 				if (nodeViewsPerNode.ContainsKey(oldInputNode) && nodeViewsPerNode.ContainsKey(oldOutputNode))
 				{
-					var edgeView = new EdgeView()
-					{
-						userData = newEdge,
-						input = nodeViewsPerNode[oldInputNode].GetPortViewFromFieldName(newEdge.inputFieldName, newEdge.inputPortIdentifier),
-						output = nodeViewsPerNode[oldOutputNode].GetPortViewFromFieldName(newEdge.outputFieldName, newEdge.outputPortIdentifier)
-					};
+					var edgeView = CreateEdgeView();
+					edgeView.userData = newEdge;
+					edgeView.input = nodeViewsPerNode[oldInputNode].GetPortViewFromFieldName(newEdge.inputFieldName, newEdge.inputPortIdentifier);
+					edgeView.output = nodeViewsPerNode[oldOutputNode].GetPortViewFromFieldName(newEdge.outputFieldName, newEdge.outputPortIdentifier);
 
 					Connect(edgeView);
 				}
 			}
 		}
 
-		GraphViewChange GraphViewChangedCallback(GraphViewChange changes)
+        protected virtual EdgeView CreateEdgeView()
+        {
+			return new EdgeView();
+        }
+
+        GraphViewChange GraphViewChangedCallback(GraphViewChange changes)
 		{
 			if (changes.elementsToRemove != null)
 			{
@@ -764,11 +767,11 @@ void InitializeEdgeViews()
 				if (inputNodeView == null || outputNodeView == null)
 					continue;
 
-				var edgeView = new EdgeView() {
-					userData = serializedEdge,
-					input = inputNodeView.GetPortViewFromFieldName(serializedEdge.inputFieldName, serializedEdge.inputPortIdentifier),
-					output = outputNodeView.GetPortViewFromFieldName(serializedEdge.outputFieldName, serializedEdge.outputPortIdentifier)
-				};
+				var edgeView = CreateEdgeView();
+				edgeView.userData = serializedEdge;
+				edgeView.input = inputNodeView.GetPortViewFromFieldName(serializedEdge.inputFieldName, serializedEdge.inputPortIdentifier);
+				edgeView.output = outputNodeView.GetPortViewFromFieldName(serializedEdge.outputFieldName, serializedEdge.outputPortIdentifier);
+
 
 				ConnectView(edgeView);
 			}
@@ -1087,12 +1090,11 @@ public bool Connect(PortView inputPortView, PortView outputPortView, bool autoDi
 
 			var newEdge = SerializableEdge.CreateNewEdge(graph, inputPort, outputPort);
 
-			var edgeView = new EdgeView()
-			{
-				userData = newEdge,
-				input = inputPortView,
-				output = outputPortView,
-			};
+			var edgeView = CreateEdgeView();
+			edgeView.userData = newEdge;
+			edgeView.input = inputPortView;
+			edgeView.output = outputPortView;
+
 
 			return Connect(edgeView);
 		}

Assets/com.alelievr.NodeGraphProcessor/Editor/Views/BaseNodeView.cs

@@ -280,9 +280,10 @@ public PortView GetPortViewFromFieldName(string fieldName, string identifier)
 			});
 		}
 
+
 		public PortView AddPort(FieldInfo fieldInfo, Direction direction, BaseEdgeConnectorListener listener, PortData portData)
 		{
-			PortView p = PortView.CreatePV(direction, fieldInfo, portData, listener);
+			PortView p = CreatePortView(direction, fieldInfo, portData, listener);
 
 			if (p.direction == Direction.Input)
 			{
@@ -317,7 +318,12 @@ public PortView AddPort(FieldInfo fieldInfo, Direction direction, BaseEdgeConnec
 			return p;
 		}
 
-		public void InsertPort(PortView portView, int index)
+        protected virtual PortView CreatePortView(Orientation horizontal, Direction direction, FieldInfo fieldInfo, PortData portData, BaseEdgeConnectorListener listener)
+        {
+			return PortView.CreatePV(horizontal, direction, fieldInfo, portData, listener);
+        }
+
+        public void InsertPort(PortView portView, int index)
 		{
 			if (portView.direction == Direction.Input)
 			{

Assets/com.alelievr.NodeGraphProcessor/Editor/Views/PortView.cs

@@ -30,7 +30,7 @@ public class PortView : Port
 
 		readonly string portStyle = "GraphProcessorStyles/PortView";
 
-        PortView(Direction direction, FieldInfo fieldInfo, PortData portData, BaseEdgeConnectorListener edgeConnectorListener)
+        protected PortView(Direction direction, FieldInfo fieldInfo, PortData portData, BaseEdgeConnectorListener edgeConnectorListener)
             : base(portData.vertical ? Orientation.Vertical : Orientation.Horizontal, direction, Capacity.Multi, portData.displayType ?? fieldInfo.FieldType)
 		{
 			this.fieldInfo = fieldInfo;