Skip to content

Commit 91f40dc

Browse files
alelievralelievr
authored
Merge pull request #125 from alelievr/waitable-nodes
Waitable Nodes and Console Log Node
2 parents 300f413 + 9b08029 commit 91f40dc

File tree

14 files changed

+885
-84
lines changed

14 files changed

+885
-84
lines changed

‎Assets/Examples/ConditionalGraph/ConditionalNode.cs

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,4 +45,28 @@ public override IEnumerable< ConditionalNode > GetExecutedNodes()
4545
.GetEdges().Select(e => e.inputNode as ConditionalNode);
4646
}
4747
}
48+
49+
[System.Serializable]
50+
/// <summary>
51+
/// This class represent a waitable node which invokes another node after a time/frame
52+
/// </summary>
53+
public abstract class WaitableNode : LinearConditionalNode
54+
{
55+
[Output(name = "Execute After")]
56+
public ConditionalLink executeAfter;
57+
58+
protected void ProcessFinished()
59+
{
60+
onProcessFinished.Invoke(this);
61+
}
62+
63+
[HideInInspector]
64+
public Action<WaitableNode> onProcessFinished;
65+
66+
public IEnumerable< ConditionalNode > GetExecuteAfterNodes()
67+
{
68+
return outputPorts.FirstOrDefault(n => n.fieldName == nameof(executeAfter))
69+
.GetEdges().Select(e => e.inputNode as ConditionalNode);
70+
}
71+
}
4872
}

‎Assets/Examples/ConditionalGraph/ConditionalProcessor.cs

Lines changed: 119 additions & 84 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,31 @@ public override void UpdateComputeOrder()
4343

4444
public override void Run()
4545
{
46-
// Execute the whole graph:
47-
var enumerator = RunConditionalGraph();
46+
IEnumerator<BaseNode> enumerator;
4847

49-
while (enumerator.MoveNext())
48+
if(startNodeList.Count == 0)
49+
{
50+
enumerator = RunTheGraph();
51+
}
52+
else
53+
{
54+
Stack<BaseNode> nodeToExecute = new Stack<BaseNode>();
55+
// Add all the start nodes to the execution stack
56+
startNodeList.ForEach(s => nodeToExecute.Push(s));
57+
// Execute the whole graph:
58+
enumerator = RunTheGraph(nodeToExecute);
59+
}
60+
61+
while(enumerator.MoveNext())
62+
;
63+
}
64+
65+
private void WaitedRun(Stack<BaseNode> nodesToRun)
66+
{
67+
// Execute the waitable node:
68+
var enumerator = RunTheGraph(nodesToRun);
69+
70+
while(enumerator.MoveNext())
5071
;
5172
}
5273

@@ -67,96 +88,110 @@ IEnumerable<BaseNode> GatherNonConditionalDependencies(BaseNode node)
6788
yield return dependency;
6889
}
6990
}
70-
71-
public IEnumerator<BaseNode> RunConditionalGraph()
91+
92+
private IEnumerator<BaseNode> RunTheGraph()
7293
{
73-
if (startNodeList.Count == 0)
74-
{
75-
int count = processList.Count;
94+
int count = processList.Count;
7695

77-
for (int i = 0; i < count; i++)
78-
{
79-
processList[i].OnProcess();
80-
yield return processList[i];
81-
}
82-
}
83-
else // Conditional graph execution:
96+
for(int i = 0; i < count; i++)
8497
{
85-
Stack<BaseNode> nodeToExecute = new Stack<BaseNode>();
86-
HashSet<BaseNode> nodeDependenciesGathered = new HashSet<BaseNode>();
87-
HashSet<BaseNode> skipConditionalHandling = new HashSet<BaseNode>();
88-
89-
// Add all the start nodes to the execution stack
90-
startNodeList.ForEach(s => nodeToExecute.Push(s));
91-
92-
while (nodeToExecute.Count > 0)
93-
{
94-
var node = nodeToExecute.Pop();
95-
// TODO: maxExecutionTimeMS
96-
97-
// In case the node is conditional, then we need to execute it's non-conditional dependencies first
98-
if (node is IConditionalNode && !skipConditionalHandling.Contains(node))
99-
{
100-
// Gather non-conditional deps: TODO, move to the cache:
101-
if (nodeDependenciesGathered.Contains(node))
102-
{
103-
// Execute the conditional node:
104-
node.OnProcess();
105-
yield return node;
106-
107-
// And select the next nodes to execute:
108-
switch (node)
109-
{
110-
// special code path for the loop node as it will execute multiple times the same nodes
111-
case ForLoopNode forLoopNode:
112-
forLoopNode.index = forLoopNode.start - 1; // Initialize the start index
113-
foreach (var n in forLoopNode.GetExecutedNodesLoopCompleted())
114-
nodeToExecute.Push(n);
115-
for (int i = forLoopNode.start; i < forLoopNode.end; i++)
116-
{
117-
foreach (var n in forLoopNode.GetExecutedNodesLoopBody())
118-
nodeToExecute.Push(n);
119-
120-
nodeToExecute.Push(node); // Increment the counter
121-
}
122-
skipConditionalHandling.Add(node);
123-
break;
124-
case IConditionalNode cNode:
125-
foreach (var n in cNode.GetExecutedNodes())
126-
nodeToExecute.Push(n);
127-
break;
128-
default:
129-
Debug.LogError($"Conditional node {node} not handled");
130-
break;
131-
}
132-
nodeDependenciesGathered.Remove(node);
133-
}
134-
else
135-
{
136-
nodeToExecute.Push(node);
137-
nodeDependenciesGathered.Add(node);
138-
foreach (var nonConditionalNode in GatherNonConditionalDependencies(node))
139-
{
140-
nodeToExecute.Push(nonConditionalNode);
141-
}
142-
}
143-
}
144-
else
145-
{
146-
node.OnProcess();
147-
yield return node;
148-
}
149-
}
98+
processList[i].OnProcess();
99+
yield return processList[i];
150100
}
151101
}
152-
153-
// Advance the execution of the graph of one node, mostly for debug
102+
103+
private IEnumerator<BaseNode> RunTheGraph(Stack<BaseNode> nodeToExecute)
104+
{
105+
HashSet<BaseNode> nodeDependenciesGathered = new HashSet<BaseNode>();
106+
HashSet<BaseNode> skipConditionalHandling = new HashSet<BaseNode>();
107+
108+
while(nodeToExecute.Count > 0)
109+
{
110+
var node = nodeToExecute.Pop();
111+
// TODO: maxExecutionTimeMS
112+
113+
// In case the node is conditional, then we need to execute it's non-conditional dependencies first
114+
if(node is IConditionalNode && !skipConditionalHandling.Contains(node))
115+
{
116+
// Gather non-conditional deps: TODO, move to the cache:
117+
if(nodeDependenciesGathered.Contains(node))
118+
{
119+
// Execute the conditional node:
120+
node.OnProcess();
121+
yield return node;
122+
123+
// And select the next nodes to execute:
124+
switch(node)
125+
{
126+
// special code path for the loop node as it will execute multiple times the same nodes
127+
case ForLoopNode forLoopNode:
128+
forLoopNode.index = forLoopNode.start - 1; // Initialize the start index
129+
foreach(var n in forLoopNode.GetExecutedNodesLoopCompleted())
130+
nodeToExecute.Push(n);
131+
for(int i = forLoopNode.start; i < forLoopNode.end; i++)
132+
{
133+
foreach(var n in forLoopNode.GetExecutedNodesLoopBody())
134+
nodeToExecute.Push(n);
135+
136+
nodeToExecute.Push(node); // Increment the counter
137+
}
138+
139+
skipConditionalHandling.Add(node);
140+
break;
141+
// another special case for waitable nodes, like "wait for a coroutine", wait x seconds", etc.
142+
case WaitableNode waitableNode:
143+
foreach(var n in waitableNode.GetExecutedNodes())
144+
nodeToExecute.Push(n);
145+
146+
waitableNode.onProcessFinished += (waitedNode) =>
147+
{
148+
Stack<BaseNode> waitedNodes = new Stack<BaseNode>();
149+
foreach(var n in waitedNode.GetExecuteAfterNodes())
150+
waitedNodes.Push(n);
151+
WaitedRun(waitedNodes);
152+
waitableNode.onProcessFinished = null;
153+
};
154+
break;
155+
case IConditionalNode cNode:
156+
foreach(var n in cNode.GetExecutedNodes())
157+
nodeToExecute.Push(n);
158+
break;
159+
default:
160+
Debug.LogError($"Conditional node {node} not handled");
161+
break;
162+
}
163+
164+
nodeDependenciesGathered.Remove(node);
165+
}
166+
else
167+
{
168+
nodeToExecute.Push(node);
169+
nodeDependenciesGathered.Add(node);
170+
foreach(var nonConditionalNode in GatherNonConditionalDependencies(node))
171+
{
172+
nodeToExecute.Push(nonConditionalNode);
173+
}
174+
}
175+
}
176+
else
177+
{
178+
node.OnProcess();
179+
yield return node;
180+
}
181+
}
182+
}
183+
184+
// Advance the execution of the graph of one node, mostly for debug. Doesn't work for WaitableNode's executeAfter port.
154185
public void Step()
155186
{
156187
if (currentGraphExecution == null)
157188
{
158-
currentGraphExecution = RunConditionalGraph();
159-
currentGraphExecution.MoveNext(); // Advance to the first node
189+
Stack<BaseNode> nodeToExecute = new Stack<BaseNode>();
190+
if(startNodeList.Count > 0)
191+
startNodeList.ForEach(s => nodeToExecute.Push(s));
192+
193+
currentGraphExecution = startNodeList.Count == 0 ? RunTheGraph() : RunTheGraph(nodeToExecute);
194+
currentGraphExecution.MoveNext(); // Advance to the first node
160195
}
161196
else
162197
if (!currentGraphExecution.MoveNext())

‎Assets/Examples/DefaultNodes/Nodes/ConsoleLogNode.cs

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
using System;
2+
using GraphProcessor;
3+
using UnityEngine;
4+
5+
namespace NodeGraphProcessor.Examples
6+
{
7+
[Serializable, NodeMenuItem("Debug/Console Log")]
8+
public class ConsoleNode : LinearConditionalNode
9+
{
10+
public override string name => "Console Log";
11+
12+
[Input("Object")]
13+
public object obj;
14+
15+
[Input("Log"), SerializeField, Tooltip("If Object is null, this will be the log.")]
16+
public string logText = "Log";
17+
18+
[Setting("Log Type")]
19+
public LogType logType = LogType.Log;
20+
21+
protected override void Process()
22+
{
23+
switch(logType)
24+
{
25+
case LogType.Error:
26+
case LogType.Exception:
27+
Debug.LogError(obj != null ? obj.ToString() : logText);
28+
break;
29+
case LogType.Assert:
30+
Debug.LogAssertion(obj != null ? obj.ToString() : logText);
31+
break;
32+
case LogType.Warning:
33+
Debug.LogWarning(obj != null ? obj.ToString() : logText);
34+
break;
35+
case LogType.Log:
36+
Debug.Log(obj != null ? obj.ToString() : logText);
37+
break;
38+
}
39+
}
40+
}
41+
}

‎Assets/Examples/DefaultNodes/Nodes/ConsoleLogNode.cs.meta

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎Assets/Examples/DefaultNodes/Nodes/WaitFrameNode.cs

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
1+
using System;
2+
using System.Collections;
3+
using GraphProcessor;
4+
using UnityEngine;
5+
6+
namespace NodeGraphProcessor.Examples
7+
{
8+
[Serializable, NodeMenuItem("Functions/Wait Frames")]
9+
public class WaitFrameNode : WaitableNode
10+
{
11+
public override string name => "Wait Frames";
12+
13+
[SerializeField, Input(name = "Frames")]
14+
public int frame = 1;
15+
16+
private static WaitFrameMonoBehaviour waitFrameMonoBehaviour;
17+
18+
protected override void Process()
19+
{
20+
if(waitFrameMonoBehaviour == null)
21+
{
22+
var go = new GameObject(name: "WaitFrameGameObject");
23+
waitFrameMonoBehaviour = go.AddComponent<WaitFrameMonoBehaviour>();
24+
}
25+
26+
waitFrameMonoBehaviour.Process(frame, ProcessFinished);
27+
}
28+
}
29+
30+
public class WaitFrameMonoBehaviour : MonoBehaviour
31+
{
32+
public void Process(int frame, Action callback)
33+
{
34+
StartCoroutine(_Process(frame, callback));
35+
}
36+
37+
private IEnumerator _Process(int frame, Action callback)
38+
{
39+
for(int i = 0; i < frame; i++)
40+
{
41+
yield return new WaitForEndOfFrame();
42+
i++;
43+
}
44+
45+
callback.Invoke();
46+
}
47+
}
48+
}

‎Assets/Examples/DefaultNodes/Nodes/WaitFrameNode.cs.meta

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)