Skip to content

Commit ac8a6a3

Browse files
committed
Fixed fields with [Settings] attribute not showing up with inheritance
1 parent efd190c commit ac8a6a3

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

Assets/com.alelievr.NodeGraphProcessor/Editor/Views/BaseNodeView.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ void InitializeSettings()
248248
settingsContainer.Add(settings);
249249
Add(settingsContainer);
250250

251-
var fields = nodeTarget.GetType().GetFields(BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance | BindingFlags.DeclaredOnly);
251+
var fields = nodeTarget.GetType().GetFields(BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance);
252252

253253
foreach(var field in fields)
254254
if(field.GetCustomAttribute(typeof(SettingAttribute)) != null)
@@ -907,7 +907,7 @@ protected VisualElement AddControlField(FieldInfo field, string label = null, bo
907907
if (visibleCondition != null)
908908
{
909909
// Check if target field exists:
910-
var conditionField = nodeTarget.GetType().GetField(visibleCondition.fieldName, BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance | BindingFlags.DeclaredOnly);
910+
var conditionField = nodeTarget.GetType().GetField(visibleCondition.fieldName, BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance);
911911
if (conditionField == null)
912912
Debug.LogError($"[VisibleIf] Field {visibleCondition.fieldName} does not exists in node {nodeTarget.GetType()}");
913913
else

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@ All notable changes to this package will be documented in this file.
44
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
55
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
66

7+
## [1.4.0]
8+
9+
### Fixed
10+
- Fixed fields with [Settings] attribute not showing up with inheritance.
11+
712
## [1.3.0]
813

914
### Added

0 commit comments

Comments
 (0)