Skip to content

Commit b804c94

Browse files
committed
ReviewNode and PortView customization patch
1 parent 03d1dd9 commit b804c94

File tree

5 files changed

+13
-7
lines changed

5 files changed

+13
-7
lines changed

Assets/com.alelievr.NodeGraphProcessor/Editor/Utils/BaseEdgeConnector.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public BaseEdgeConnector(IEdgeConnectorListener listener) : base()
2222
initEdgeConnector(listener);
2323
}
2424

25-
protected void initEdgeConnector(IEdgeConnectorListener listener)
25+
protected virtual void initEdgeConnector(IEdgeConnectorListener listener)
2626
{
2727
dragHelper = new BaseEdgeDragHelper(listener);
2828
activators.Add(new ManipulatorActivationFilter { button = MouseButton.LeftMouse });
@@ -86,7 +86,7 @@ protected virtual void OnMouseDown(MouseDownEvent e)
8686
}
8787
}
8888

89-
protected EdgeView CreateEdgeView()
89+
protected virtual EdgeView CreateEdgeView()
9090
{
9191
return new EdgeView();
9292
}

Assets/com.alelievr.NodeGraphProcessor/Editor/Utils/BaseEdgeDragHelper.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ public override void HandleMouseMove(MouseMoveEvent evt)
260260
}
261261
}
262262

263-
protected EdgeView CreateEdgeView()
263+
protected virtual EdgeView CreateEdgeView()
264264
{
265265
return new EdgeView();
266266
}

Assets/com.alelievr.NodeGraphProcessor/Editor/Views/BaseGraphView.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ void UnserializeAndPasteCallback(string operationName, string serializedData)
292292
}
293293
}
294294

295-
protected EdgeView CreateEdgeView()
295+
protected virtual EdgeView CreateEdgeView()
296296
{
297297
return new EdgeView();
298298
}

Assets/com.alelievr.NodeGraphProcessor/Editor/Views/BaseNodeView.cs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -263,10 +263,11 @@ public PortView GetPortViewFromFieldName(string fieldName, string identifier)
263263
});
264264
}
265265

266+
266267
public PortView AddPort(FieldInfo fieldInfo, Direction direction, BaseEdgeConnectorListener listener, PortData portData)
267268
{
268269
// TODO: hardcoded value
269-
PortView p = PortView.CreatePV(Orientation.Horizontal, direction, fieldInfo, portData, listener);
270+
PortView p = CreatePortView(Orientation.Horizontal, direction, fieldInfo, portData, listener);
270271

271272
if (p.direction == Direction.Input)
272273
{
@@ -293,7 +294,12 @@ public PortView AddPort(FieldInfo fieldInfo, Direction direction, BaseEdgeConnec
293294
return p;
294295
}
295296

296-
public void InsertPort(PortView portView, int index)
297+
protected virtual PortView CreatePortView(Orientation horizontal, Direction direction, FieldInfo fieldInfo, PortData portData, BaseEdgeConnectorListener listener)
298+
{
299+
return PortView.CreatePV(horizontal, direction, fieldInfo, portData, listener);
300+
}
301+
302+
public void InsertPort(PortView portView, int index)
297303
{
298304
if (portView.direction == Direction.Input)
299305
inputContainer.Insert(index, portView);

Assets/com.alelievr.NodeGraphProcessor/Editor/Views/PortView.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public class PortView : Port
3030

3131
readonly string portStyle = "GraphProcessorStyles/PortView";
3232

33-
PortView(Orientation orientation, Direction direction, FieldInfo fieldInfo, PortData portData, BaseEdgeConnectorListener edgeConnectorListener)
33+
protected PortView(Orientation orientation, Direction direction, FieldInfo fieldInfo, PortData portData, BaseEdgeConnectorListener edgeConnectorListener)
3434
: base(orientation, direction, Capacity.Multi, portData.displayType ?? fieldInfo.FieldType)
3535
{
3636
this.fieldInfo = fieldInfo;

0 commit comments

Comments
 (0)