Remove extract css options

Author: ije

framework/react/components/StyleLink.ts

@@ -5,8 +5,11 @@ import { inDeno } from '../helper.ts'
 const useIsomorphicLayoutEffect = inDeno ? useEffect : useLayoutEffect
 
 export default function StyleLink({ href }: { href: string }) {
-  useIsomorphicLayoutEffect(() => {
+  if (!inDeno) {
     recoverCSS(href)
+  }
+
+  useIsomorphicLayoutEffect(() => {
     return () => removeCSS(href, true)
   }, [])
 

plugins/css.ts

@@ -133,23 +133,6 @@ export const cssLoader = async ({ specifier, data }: LoadInput, aleph: Aleph): P
     return { type: 'css', code: css }
   }
 
-  const { extract: { limit = 8 * 1024 } } = cssConfig
-  if (css.length > limit) {
-    const ext = extname(specifier)
-    const hash = computeHash(css).slice(0, 8)
-    const path = util.trimSuffix(isRemote ? toLocalPath(specifier) : specifier, ext) + '.' + hash + ext
-    await aleph.addDist(path, (new TextEncoder).encode(css))
-    return {
-      code: [
-        `import { applyCSS } from "https://deno.land/x/aleph/framework/core/style.ts"`,
-        `export const href = ${JSON.stringify('/_aleph/' + util.trimPrefix(path, '/'))}`,
-        `export default ${JSON.stringify(modulesJSON)}`,
-        `applyCSS(${JSON.stringify(specifier)}, { href })`
-      ].join('\n'),
-      // todo: generate map
-    }
-  }
-
   return {
     code: [
       `import { applyCSS } from "https://deno.land/x/aleph/framework/core/style.ts"`,

plugins/css_test.ts

@@ -28,26 +28,6 @@ Deno.test('plugin: css loader', async () => {
   assert(!isCSS('/style/index.sass'))
 })
 
-Deno.test('plugin: css loader with extract size option', async () => {
-  Deno.env.set('DENO_TESTING', 'true')
-  const dir = await Deno.makeTempDir({ prefix: 'aleph_plugin_testing' })
-  const aleph = new Aleph(dir, 'development')
-  aleph.config.css.extract = { limit: 10 }
-  await ensureTextFile(
-    join(dir, '/style/index.css'),
-    'h1 { font-size: 18px; }'
-  )
-  const { code } = await cssLoader({ specifier: '/style/index.css', }, aleph)
-  const distPath = `/style/index.${computeHash('h1 { font-size: 18px; }').slice(0, 8)}.css`
-  assertEquals(code, [
-    'import { applyCSS } from "https://deno.land/x/aleph/framework/core/style.ts"',
-    `export const href = "/_aleph${distPath}"`,
-    'export default {}',
-    'applyCSS("/style/index.css", { href })',
-  ].join('\n'))
-  assert(await exists(join(aleph.buildDir, distPath)))
-})
-
 Deno.test('plugin: css loader for remote external', async () => {
   Deno.env.set('DENO_TESTING', 'true')
   const dir = await Deno.makeTempDir({ prefix: 'aleph_plugin_testing' })

server/aleph.ts

@@ -1304,7 +1304,7 @@ export class Aleph implements IAleph {
           }
           depModule = mod
         }
-        if (!ignoreDeps && depModule) {
+        if (depModule) {
           const hash = depModule.hash || depModule.sourceHash
           if (hashLoc !== undefined) {
             if (await this.replaceDepHash(module, hashLoc, hash)) {

server/config.ts

@@ -31,9 +31,6 @@ export function defaultConfig(): Readonly<RequiredConfig> {
     css: {
       cache: true,
       modules: {},
-      extract: {
-        limit: 8 * 1024
-      },
       postcss: { plugins: ['autoprefixer'] },
     },
     server: {
@@ -131,7 +128,6 @@ export async function loadConfig(specifier: string): Promise<Config> {
     }
     config.css = {
       cache,
-      extract: util.isPlainObject(extract) && typeof extract.limit === 'number' ? extract as any : { limit: 8 * 1024 },
       modules: util.isPlainObject(modules) ? modules : {},
       postcss: isPostcssConfig(postcss) ? postcss : { plugins: ['autoprefixer'] }
     }

types.d.ts

@@ -187,8 +187,6 @@ export type ImportMap = {
 export type CSSOptions = {
   /** `cache` caches remote css to local if it is true. */
   cache?: boolean | RegExp | RegExp[]
-  /** `extract` specifies the extract options (default is true with 8k limit). */
-  extract?: { limit: number }
   /** `postcss` specifies the postcss plugins. */
   postcss?: { plugins: PostCSSPlugin[] }
   /** `modules` specifies CSS modules behavior. */