Skip to content
This repository was archived by the owner on Jul 6, 2025. It is now read-only.

Commit 3eb8129

Browse files
committed
Remove resolveStarExports compile option
1 parent a84c37c commit 3eb8129

File tree

4 files changed

+2
-15
lines changed

4 files changed

+2
-15
lines changed

compiler/mod.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ export type TransformOptions = {
4040
sourceMap?: boolean
4141
isDev?: boolean
4242
transpileOnly?: boolean
43-
resolveStarExports?: boolean
4443
bundleMode?: boolean
4544
bundleExternal?: string[]
4645
inlineStylePreprocess?(key: string, type: string, tpl: string): Promise<string>

compiler/src/lib.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,6 @@ pub struct Options {
4444
#[serde(default)]
4545
pub transpile_only: bool,
4646

47-
#[serde(default)]
48-
pub resolve_star_exports: bool,
49-
5047
#[serde(default)]
5148
pub bundle_mode: bool,
5249

@@ -152,7 +149,6 @@ pub fn transform_sync(url: &str, code: &str, options: JsValue) -> Result<JsValue
152149
source_map: options.source_map,
153150
is_dev: options.is_dev,
154151
transpile_only: options.transpile_only,
155-
resolve_star_exports: options.resolve_star_exports,
156152
},
157153
)
158154
.expect("could not transform module");

compiler/src/swc.rs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ pub struct EmitOptions {
3232
pub jsx_fragment_factory: String,
3333
pub is_dev: bool,
3434
pub transpile_only: bool,
35-
pub resolve_star_exports: bool,
3635
pub source_map: bool,
3736
}
3837

@@ -44,7 +43,6 @@ impl Default for EmitOptions {
4443
jsx_fragment_factory: "React.Fragment".into(),
4544
is_dev: false,
4645
transpile_only: false,
47-
resolve_star_exports: false,
4846
source_map: false,
4947
}
5048
}
@@ -147,11 +145,7 @@ impl SWC {
147145
aleph_jsx_fold(resolver.clone(), self.source_map.clone(), options.is_dev);
148146
let mut passes = chain!(
149147
Optional::new(
150-
resolve_fold(
151-
resolver.clone(),
152-
self.source_map.clone(),
153-
options.resolve_star_exports,
154-
),
148+
resolve_fold(resolver.clone(), self.source_map.clone(), !options.is_dev,),
155149
!transpile_only
156150
),
157151
Optional::new(aleph_jsx_fold, is_jsx && !transpile_only),

server/app.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1118,16 +1118,14 @@ export class Application implements ServerApplication {
11181118
target: 'es2020',
11191119
sourceType: source.type
11201120
},
1121-
// workaround for https://github.com/denoland/deno/issues/9849
1122-
resolveStarExports: !this.isDev && Deno.version.deno.replace(/\.\d+$/, '') === '1.8',
11231121
})
11241122

11251123
jsContent = code
11261124
if (map) {
11271125
jsSourceMap = map
11281126
}
11291127

1130-
// workaround for https://github.com/denoland/deno/issues/9849
1128+
// in bundle mode we replace the star export with names
11311129
if (starExports && starExports.length > 0) {
11321130
for (let index = 0; index < starExports.length; index++) {
11331131
const url = starExports[index]

0 commit comments

Comments
 (0)