Merge pull request #268 from cdoremus/add-test-redirect

test: Add tests for redirect.ts

Author: ije

CONTRIBUTING.md

@@ -18,7 +18,7 @@ You will need [Deno](https://deno.land/) 1.8+.
 4. Change code then run the examples.
 5. Push your branch to Github after all tests passed.
 6. Make a [pull request](https://github.com/alephjs/aleph.js/pulls).
-7. Marge to master branch by our maintainers.
+7. Merge to master branch by our maintainers.
 
 ```bash
 # ssr/development with HMR
@@ -31,7 +31,7 @@ ALEPH_DEV=true deno run -A --unstable --import-map=./import_map.json cli.ts star
 ALEPH_DEV=true deno run -A --unstable --import-map=./import_map.json cli.ts build ./examples/hello-world -L debug
 
 # run all tests
-deno test -A --unstable --import-map=./import_map.json
+deno test -A --unstable --location=http://127.0.0.1 --import-map=./import_map.json
 ```
 
 ## Project Structure

framework/core/redirect_test.ts

@@ -0,0 +1,85 @@
+/**
+ * NOTE: This test needs the --location cli flag set
+ * see https://github.com/denoland/deno/blob/main/docs/runtime/location_api.md
+ * and explanation below.
+ */
+import { assertEquals } from 'std/testing/asserts.ts'
+import { redirect } from './redirect.ts'
+
+// mock history functions used in redirect()
+interface MockWindow extends Window {
+    history: {
+        replaceState: (state: object | null, title: string | '', url?: string) => void,
+        pushState: (state: object | null, title: string | '', url?: string) => void
+    }
+}
+declare let window: MockWindow
+
+// track calls to history functions
+const calls = {
+    pushCalls: 0, // tracks calls to pushState()
+    replaceCalls: 0 // tracks calls to replaceState()
+}
+// create mock history impl
+window.history = {
+    replaceState: (url) => { calls.replaceCalls++; return null },
+    pushState: (url) => { calls.pushCalls++; return null }
+}
+
+const resetCallCount = () => {
+    calls.pushCalls = 0
+    calls.replaceCalls = 0
+}
+
+Deno.test('redirect: replace=false should call history.pushState', () => {
+    const url = '/foo/bar.ts'
+
+    redirect(url)
+    assertEquals(calls.pushCalls, 1)
+    redirect(url)
+    assertEquals(calls.pushCalls, 2)
+    redirect(url)
+    assertEquals(calls.pushCalls, 3)
+
+    resetCallCount()
+})
+
+Deno.test('redirect: replace=true should call history.replaceState', () => {
+    const url = '/foo/bar2.ts'
+
+    redirect(url, true)
+    assertEquals(calls.replaceCalls, 1)
+    redirect(url, true)
+
+    assertEquals(calls.replaceCalls, 2)
+
+    resetCallCount()
+})
+
+Deno.test('redirect: empty string url should not call history methods', () => {
+    const url = ''
+
+    redirect(url)
+
+    assertEquals(calls.pushCalls, 0)
+    assertEquals(calls.replaceCalls, 0)
+
+})
+
+/**
+ * This fails because setting location.href is not allowed in a
+ * non-browser environment. see
+ * https://github.com/denoland/deno/blob/main/docs/runtime/location_api.md
+ * This errors out on line 12 of redirect().
+ */
+// Deno.test('redirect: file url should set location.href', () => {
+//     const url = 'file://foo/file.ts'
+
+//     redirect(url)
+
+//     assertEquals(window.location.href, url)
+//     assertEquals(calls.pushCalls, 0)
+//     assertEquals(calls.replaceCalls, 0)
+
+//     resetCallCount()
+// })

shared/fs_test.ts

@@ -8,7 +8,7 @@ import {
 } from './fs.ts'
 
 
-Deno.test(`fs existsDirSync`, () => {
+Deno.test(`fs: existsDirSync`, () => {
     // true test cases
     const dir = Deno.makeTempDirSync()
     assert(existsDirSync(dir))
@@ -22,7 +22,7 @@ Deno.test(`fs existsDirSync`, () => {
 })
 
 
-Deno.test(`fs async existsDir`, async () => {
+Deno.test(`fs: async existsDir`, async () => {
     // true test cases
     assert(await existsDir(await Deno.realPath(getStandardFolder())))
     const dir = await Deno.makeTempDir()
@@ -31,13 +31,9 @@ Deno.test(`fs async existsDir`, async () => {
     assertEquals(await existsDir(`${dir}${SEP}foobar`), false)
     const file = await Deno.makeTempFile()
     assertEquals(await existsDir(file), false)
-    // error test cases
-    existsDir({} as string).then(err => {
-        assert(err instanceof Error)
-    }).catch(e => console.error(e))
 })
 
-Deno.test(`fs existsFileSync`, () => {
+Deno.test(`fs: existsFileSync`, () => {
     // true test cases
     const file = Deno.makeTempFileSync()
     assert(existsFileSync(file))
@@ -49,21 +45,17 @@ Deno.test(`fs existsFileSync`, () => {
     assertThrows(() => existsDirSync({} as string), Error)
 })
 
-Deno.test(`fs async existsFile`, async () => {
+Deno.test(`fs: async existsFile`, async () => {
     // true test cases
     const file = await Deno.makeTempFile()
     assert(await existsFile(file))
     // false test cases
     const dir = Deno.makeTempDirSync()
     assertEquals(await existsFile(dir), false)
     assertEquals(await existsFileSync(`${dir}${SEP}llksdafzxc.ts`), false)
-    // error test cases
-    existsFile({} as string).then(err => {
-        assert(err instanceof Error)
-    }).catch(e => console.error(e))
 })
 
-Deno.test('ensureTextFile', async () => {
+Deno.test('fs: ensureTextFile', async () => {
     // true test case
     const dirPath = await Deno.makeTempDir()
     const textFilePath = `${dirPath}${SEP}test.txt`
@@ -84,7 +76,7 @@ Deno.test('ensureTextFile', async () => {
     }
 })
 
-Deno.test('lazyRemove', async () => {
+Deno.test('fs: lazyRemove', async () => {
     // true test case
     const filePath = await Deno.makeTempFile()
     await lazyRemove(filePath)
@@ -93,11 +85,6 @@ Deno.test('lazyRemove', async () => {
     const dirPath = await Deno.makeTempDir()
     await lazyRemove(`${dirPath}${SEP}asdfsdf.txt`)
     assert(await existsDir(dirPath))
-    // error test
-    lazyRemove({} as string).then(err => {
-        assert(err instanceof Error)
-    }).catch(e => console.error(e))
-
 })