directly implement Display instead of ToString, satiate clippy

Author: alerque

src/app.rs

@@ -79,15 +79,15 @@ impl FromStr for DiffType {
     }
 }
 
-impl ToString for DiffType {
-    fn to_string(&self) -> String {
-        match self {
+impl std::fmt::Display for DiffType {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        let s = match self {
             DiffType::Added => "+",
             DiffType::Deleted => "-",
             DiffType::Modified => "m",
             DiffType::Renamed => "r",
-        }
-        .to_string()
+        };
+        write!(f, "{}", s)
     }
 }
 

src/main.rs

@@ -76,8 +76,8 @@ fn main() {
     });
 }
 
-fn setup_logger(log_level: &String) {
-    let level = match log_level.as_str() {
+fn setup_logger(log_level: &str) {
+    let level = match log_level {
         "error" => log::LevelFilter::Error,
         "warn" => log::LevelFilter::Warn,
         "info" => log::LevelFilter::Info,

src/ui.rs

@@ -290,12 +290,12 @@ fn draw_files<B: Backend>(f: &mut Frame<B>, target: Rect, app: &mut App) {
                     let style = Style::default().fg(item.diff_type.to_color());
                     FileListItem::new(
                         Span::styled(&item.file, style),
-                        Span::styled(format!("{} ", item.diff_type.to_string()), style),
+                        Span::styled(format!("{} ", item.diff_type), style),
                     )
                 } else {
                     FileListItem::new(
                         Span::raw(&item.file),
-                        Span::raw(format!("{} ", item.diff_type.to_string())),
+                        Span::raw(format!("{} ", item.diff_type)),
                     )
                 }
             })