Skip to content

Commit a605015

Browse files
authored
migrate: replace local feature deno w/ feature-setup-deno (#26)
this changeset is to replace the local feature deno with the packaged version. - replace base image with ubuntu - use bun packages to install docsify cli - replace deno local feature with feature-setup-deno v1 - remove installing deno vs code extension
1 parent f1a7ecd commit a605015

File tree

4 files changed

+9
-82
lines changed

4 files changed

+9
-82
lines changed

.devcontainer/devcontainer.json

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
{
22
"name": "docsify-footer",
3-
// See complete list https://hub.docker.com/r/oven/bun
4-
"image": "oven/bun",
3+
// See complete list https://hub.docker.com/_/microsoft-dotnet-sdk/
4+
// Or https://mcr.microsoft.com/v2/dotnet/sdk/tags/list
5+
"image": "mcr.microsoft.com/devcontainers/base:ubuntu",
56
// Use 'forwardPorts' to make a list of ports inside the container available locally.
67
"forwardPorts": [
78
// Http
@@ -14,12 +15,15 @@
1415
"ghcr.io/devcontainers/features/common-utils:2": {
1516
"configureZshAsDefaultShell": true
1617
},
18+
"ghcr.io/alertbox/oven-sh/bun:1": {
19+
"packages": "docsify-cli"
20+
},
21+
"ghcr.io/alertbox/denoland/deno:1": {},
1722
"ghcr.io/devcontainers/features/github-cli:1": {},
1823
"ghcr.io/devcontainers/features/docker-outside-of-docker:1": {
1924
"moby": false,
2025
"dockerDashComposeVersion": "v2"
21-
},
22-
"./local-features/deno": {}
26+
}
2327
},
2428
"remoteEnv": {},
2529
// Configure tool-specific properties.
@@ -28,8 +32,6 @@
2832
"vscode": {
2933
// Add the IDs of extensions you want installed when the container is created.
3034
"extensions": [
31-
// JavaScript
32-
"oven.bun-vscode",
3335
// TypeScript
3436
"bierner.lit-html",
3537
"better-ts-errors.better-ts-errors",
@@ -59,9 +61,7 @@
5961
}
6062
},
6163
// Use 'updateContentCommand' to run commands after the container is successfully created.
62-
"updateContentCommand": {
63-
"install": "bun install --global docsify-cli"
64-
},
64+
"updateContentCommand": {},
6565
// Use 'postCreateCommand' to run commands after the container is created.
6666
"postCreateCommand": {
6767
"restore": "bun install"

.devcontainer/local-features/deno/devcontainer-feature.json

Lines changed: 0 additions & 46 deletions
This file was deleted.

.devcontainer/local-features/deno/install.sh

Lines changed: 0 additions & 20 deletions
This file was deleted.

.vscode/settings.json

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)