Stop blank ingest calls (#20)

* add gaurd to stop injest call if data is falsey

* add return statement to guard

* check for empty arrya and object

* remove extranious checks and just check if its falsey

Author: JDragovichAlertLogic

al_aws_collector.js

@@ -199,11 +199,15 @@ class AlAwsCollector {
                 return response.send(event, context, response.FAILED, {Error: exception});
             });
     }
-    
+
     send(data, callback){
         var collector = this;
         var ingestType = collector._ingestType;
-        
+
+        if(!data){
+            return callback(null);
+        }
+
         zlib.deflate(data, function(compressionErr, compressed) {
             if (compressionErr) {
                 return callback(compressionErr);

test/al_aws_collector_test.js

@@ -318,7 +318,7 @@ describe('al_aws_collector tests', function() {
     describe('mocking ingestC', function() {
         var ingestCSecmsgsStub;
         var ingestCVpcFlowStub;
-        before(function() {
+        beforeEach(function() {
             ingestCSecmsgsStub = sinon.stub(m_alCollector.IngestC.prototype, 'sendSecmsgs').callsFake(
                 function fakeFn(data, callback) {
                     return new Promise (function(resolve, reject) {
@@ -334,10 +334,23 @@ describe('al_aws_collector tests', function() {
                 });
         });
 
-        after(function() {
+        afterEach(function() {
             ingestCSecmsgsStub.restore();
             ingestCVpcFlowStub.restore();
         });
+
+        it('dont send if data is falsey', function(done) {
+            AlAwsCollector.load().then(function(creds) {
+                var collector = new AlAwsCollector(
+                    context, 'cwe', AlAwsCollector.IngestTypes.SECMSGS, '1.0.0', creds);
+                var data = '';
+                collector.send(data, function(error) {
+                    assert.ifError(error);
+                    sinon.assert.notCalled(ingestCSecmsgsStub);
+                    done();
+                });
+            });
+        });
 
         it('send secmsgs success', function(done) {
             AlAwsCollector.load().then(function(creds) {