Do not include DL blob stats into checkin if DL container is not found. (#17)

* Do not include DL blob stats into checkin if DL container is not found.

* Report DL container not found if customer deletes it

* Don't try to get DL blob stats if APP_DL_CONTAINER_NAME is not set

* Fix tests

Author: kkuzmin

dlblob.js

@@ -64,7 +64,7 @@ class AlAzureDlBlob {
     }
 
     /**
-     *  @function Retrievs the first page (5000) of dead letter blobs and finds the one with the maximum size.
+     *  @function Retrieves the first page (5000) of dead letter blobs and finds the one with the maximum size.
      *  
      *  @param callback
      *  @returns callback

master.js

@@ -334,7 +334,11 @@ class AlAzureMaster {
                 });
             }),
             async.reflect(function(callback) {
-                return master._alAzureDlBlob.getDlBlobStats(callback);
+                if (process.env.APP_DL_CONTAINER_NAME) {
+                    return master._alAzureDlBlob.getDlBlobStats(callback);
+                } else {
+                    return callback(null, {});
+                }
             })
         ],
         function(err, results){

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@alertlogic/al-azure-collector-js",
-  "version": "1.1.2",
+  "version": "1.1.3",
   "description": "Alert Logic Azure Collector Common Library",
   "license": "MIT",
   "repository": {

test/master_test.js

@@ -15,6 +15,7 @@ const alcollector = require('@alertlogic/al-collector-js');
 
 const AlAzureMaster = require('../master').AlAzureMaster;
 const AzureWebAppStats = require('../appstats').AzureWebAppStats;
+const CollectionStatRecord = require('../appstats').CollectionStatRecord;
 const mock = require('./mock');
 
 describe('Master tests', function() {
@@ -455,6 +456,46 @@ describe('Master tests', function() {
             });
         });
 
+        it('Verify checkin ok, no DL stats', function(done) {
+            const storedDlName = process.env.APP_DL_CONTAINER_NAME;
+            delete process.env.APP_DL_CONTAINER_NAME;
+            
+            // This should not be called
+            nock('https://testappo365.blob.core.windows.net:443', {'encodedQueryParams':true})
+            .get('/alertlogic-dl')
+            .query(true)
+            .times(5)
+            .reply(404, mock.CONTAINER_NOT_FOUND);
+            
+            var master = new AlAzureMaster(mock.DEFAULT_FUNCTION_CONTEXT, 'ehub', '1.0.0');
+            master.checkin('2017-12-22T14:31:39', function(err, resp){
+                if (err) console.log(err);
+                process.env.APP_DL_CONTAINER_NAME = storedDlName;
+                let cs = new CollectionStatRecord();
+                cs.log.bytes = 10;
+                cs.log.events = 15;
+                const expectedCheckin = { 
+                    body: {
+                        version: '1.0.0',
+                        app_tenant_id: 'tenant-id',
+                        collection_stats: cs,
+                        host_id: 'existing-host-id',
+                        source_id: 'existing-source-id',
+                        statistics: [{ 'Master': { 'errors': 0, 'invocations': 2 } }, { 'Collector': { 'errors': 1, 'invocations': 10 } }, { 'Updater': { 'errors': 0, 'invocations': 0 } }],
+                        // No DL stats
+                        //dl_stats: { dl_count: 6, max_dl_size: 4257 },
+                        status: 'ok',
+                        details: []
+                    }
+                };
+                const expectedUrl = '/azure/ehub/checkin/subscription-id/kktest11-rg/kktest11-name';
+                fakeStats.restore();
+                sinon.assert.calledWith(fakePost, expectedUrl, expectedCheckin);
+                assert.equal(resp, mock.CHECKIN_RESPONSE_OK);
+                done();
+            });
+        });
+        
         it('Verify checkin error', function(done) {
             // Mock Azure HTTP calls
             nock('https://management.azure.com:443', {'encodedQueryParams':true})