Skip to content

Commit d7272c3

Browse files
anton-bAnton Benkevich
andauthored
Revert 3.5 support (#123)
* Revert "allow python 3.5 minimally (#119)" This reverts commit 6827a1c. * Revert "Add missing classifier (#121)" This reverts commit 75bce12. Co-authored-by: Anton Benkevich <[email protected]>
1 parent 3519323 commit d7272c3

File tree

8 files changed

+10
-17
lines changed

8 files changed

+10
-17
lines changed

.travis.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ jobs:
66
include:
77
- stage: test
88
name: 'Run python tests '
9-
python: 3.5
9+
python: 3.8
1010
install: pip install -U tox-travis
1111
script: tox
1212
- python: 3.6
@@ -15,14 +15,12 @@ jobs:
1515
- python: 3.7
1616
install: pip install -U tox-travis
1717
script: tox
18-
- python: 3.8
19-
install: pip install -U tox-travis
20-
script: tox
2118
- python: 3.8
2219
install:
2320
- pip install ./
2421
script: python scripts/validate_my_definition.py -d alsdkdefs/apis/assets_query/
25-
- language: sh
22+
- stage: test_other_os
23+
language: sh
2624
python: 3
2725
before_install:
2826
- choco install python3

alsdkdefs/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
# -*- coding: future_fstrings -*-
21
import os
32
from os.path import join as pjoin
43
import glob

requirements.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
jsonschema[format_nongpl]==3.2.0
22
pyyaml==5.1.2
3-
requests>=2.18
4-
future_fstrings
3+
requests>=2.18

scripts/validate_my_definition.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
#!/usr/bin/env python3
2-
# -*- coding: future_fstrings -*-
32

43
from yaml import YAMLError
54
from jsonschema.exceptions import ValidationError, RefResolutionError
@@ -9,6 +8,7 @@
98
import alsdkdefs
109
import os
1110

11+
1212
def validate_definition(definition_file):
1313
print(f"Validating {definition_file}")
1414
try:

scripts/validate_my_definition.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ elif command -v python3.7; then
99
PYTHON=python3.7
1010
elif command -v python3.6; then
1111
PYTHON=python3.6
12-
elif command -v python3.5; then
13-
PYTHON=python3.5
1412
elif command -v python3; then
1513
PYTHON=python3
1614
else

setup.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
with open('README.md') as readme_file:
44
readme = readme_file.read()
55

6-
requirements = ['jsonschema[format_nongpl]==3.2.0', 'pyyaml==5.1.2', 'requests>=2.18', 'future_fstrings']
6+
requirements = ['jsonschema[format_nongpl]==3.2.0', 'pyyaml==5.1.2', 'requests>=2.18']
77

88
setup(
99
name='alertlogic-sdk-definitions',
@@ -13,13 +13,12 @@
1313
license='MIT license',
1414
author='Alert Logic Inc.',
1515
author_email='[email protected]',
16-
python_requires='>=3.5',
16+
python_requires='>=3.6',
1717
classifiers=[
1818
'Development Status :: 3 - Alpha',
1919
'Intended Audience :: Developers',
2020
'License :: OSI Approved :: MIT License',
2121
'Natural Language :: English',
22-
'Programming Language :: Python :: 3.5',
2322
'Programming Language :: Python :: 3.6',
2423
'Programming Language :: Python :: 3.7',
2524
'Programming Language :: Python :: 3.8'
@@ -28,6 +27,8 @@
2827
long_description=readme,
2928
long_description_content_type='text/markdown',
3029
scripts=[],
30+
# yeah yeah i know, circular dependency, but we need it for test now, later i'll think how to decouple
31+
# definitions parsing/loading and client
3132
tests_require=requirements,
3233
packages=find_packages(exclude=['contrib', 'docs', 'tests*', 'troubleshooting']),
3334
include_package_data=True,

tests/test_apis_validate.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
#!/usr/bin/env python
2-
# -*- coding: future_fstrings -*-
32
"""Tests for `alertlogic-sdk-definitions` package."""
43

54
import unittest
65
import alsdkdefs
76

7+
88
class TestServiceDefs(unittest.TestCase):
99
def setUp(self):
1010
"""Setup"""

tox.ini

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,12 @@ python =
66
3.8: py38
77
3.7: py37
88
3.6: py36
9-
3.5: py35
109

1110
[testenv]
1211
deps =
1312
requests
1413
PyYaml
1514
jsonschema
16-
future_fstrings
1715
setenv =
1816
PYTHONPATH = {toxinidir}
1917

0 commit comments

Comments
 (0)