tests: update

Author: alessiofrittoli

__tests__/storage/cookie.test.ts

@@ -1,4 +1,4 @@
-import { Cookie, Priority, SameSite } from '@/storage/Cookie'
+import { Cookie, Priority, RawCookie, SameSite } from '@/storage/Cookie'
 
 
 describe( 'Cookie', () => {
@@ -145,7 +145,7 @@ describe( 'Cookie', () => {
 
 	describe( 'Cookie.toString()', () => {
 
-		const cookie = Cookie.parse( {
+		const options: RawCookie = {
 			name		: 'cookiename',
 			value		: { test: 'value' },
 			path		: '/specific-path',
@@ -157,11 +157,39 @@ describe( 'Cookie', () => {
 			sameSite	: SameSite.Lax,
 			maxAge		: Date.now() + 30 * 60 * 1000,
 			partitioned	: true,
+		}
+		const cookie = Cookie.parse( options )
+
+		it( 'correctly stringify a Cookie from options object', () => {
+			const cookieString = Cookie.toString( options )
+
+			expect( cookieString.includes( `${ cookie.get( 'name' ) }=${ JSON.stringify( cookie.get( 'value' ) ) }` ) )
+				.toBe( true )
+			expect( cookieString.includes( `Expires=${ new Date( cookie.get( 'expires' )! ).toUTCString() }` ) )
+				.toBe( true )
+			expect( cookieString.includes( `Max-Age=${ cookie.get( 'maxAge' ) }` ) )
+				.toBe( true )
+			expect( cookieString.includes( `Path=${ cookie.get( 'path' ) }` ) )
+				.toBe( true )
+			expect( cookieString.includes( `Priority=${ cookie.get( 'priority' ) }` ) )
+				.toBe( true )
+			expect( cookieString.includes( `Domain=${ cookie.get( 'domain' ) }` ) )
+				.toBe( true )
+			expect( cookieString.includes( `HttpOnly=${ cookie.get( 'httpOnly' ) }` ) )
+				.toBe( true )
+			expect( cookieString.includes( `Secure=${ cookie.get( 'secure' ) }` ) )
+				.toBe( true )
+			expect( cookieString.includes( `SameSite=${ cookie.get( 'sameSite' ) }` ) )
+				.toBe( true )
+			expect( cookieString.includes( `Partitioned=${ cookie.get( 'partitioned' ) }` ) )
+				.toBe( true )
 		} )
 
-		const cookieString = Cookie.toString( cookie )
 
 		it( 'correctly stringify a Cookie Map', () => {
+
+			const cookieString = Cookie.toString( cookie )
+
 			expect( cookieString.includes( `${ cookie.get( 'name' ) }=${ JSON.stringify( cookie.get( 'value' ) ) }` ) )
 				.toBe( true )
 			expect( cookieString.includes( `Expires=${ new Date( cookie.get( 'expires' )! ).toUTCString() }` ) )
@@ -184,6 +212,17 @@ describe( 'Cookie', () => {
 				.toBe( true )
 		} )
 
+
+		it( 'skips values with a falsey `key`', () => {
+			console.log( 'skips values with a falsey', Cookie.toString( {
+				name: 'testcookie',
+				value: 'value',
+				// @ts-expect-error fdfs
+				[null]: '2024-10-24',
+			} ) )
+			
+		} )
+
 	} )
 
 

__tests__/types.test.ts

@@ -214,6 +214,8 @@ describe( 'isTouchDevice', () => {
 	} )
 
 	it( 'returns `true` if the device is a touch device', () => {
+		Object.defineProperty( navigator, 'msMaxTouchPoints', { value: 2 } )
+		expect( isTouchDevice() ).toBe( true )
 		Object.defineProperty( window, 'ontouchstart', { value: true } )
 		expect( isTouchDevice() ).toBe( true )
 	} )

src/storage/Cookie.ts

@@ -50,7 +50,7 @@ export enum SameSite
  * Interface representing Cookie properties before it get parsed.
  * 
  */
-export interface RawCookie<K = string, V = string>
+export interface RawCookie<K = string, V = unknown>
 {
 	/**
 	 * The Cookie name.
@@ -124,7 +124,7 @@ export interface RawCookie<K = string, V = string>
  * Interface representing Cookie properties after it get parsed.
  * 
  */
-export interface ParsedCookie<K = string, V = string> extends Omit<RawCookie<K, V>, 'expires'>
+export interface ParsedCookie<K = string, V = unknown> extends Omit<RawCookie<K, V>, 'expires'>
 {
 	/**
 	 * Indicates the maximum lifetime of the cookie.
@@ -139,7 +139,7 @@ export interface ParsedCookie<K = string, V = string> extends Omit<RawCookie<K,
  * Map representation of a parsed Cookie.
  * 
  */
-export type ParsedCookieMap<K = string, V = string> = TypedMap<ParsedCookie<K, V>, false>
+export type ParsedCookieMap<K = string, V = unknown> = TypedMap<ParsedCookie<K, V>, false>
 
 
 /**
@@ -169,7 +169,7 @@ export class Cookie
 	 * @param	options The cookie options or a parsed Cookie Map.
 	 * @returns	The set Cookie Map if successful, `false` otherwise.
 	 */
-	static set<K = string, V = string>( options: RawCookie<K, V> | ParsedCookieMap<K, V> )
+	static set<K = string, V = unknown>( options: RawCookie<K, V> | ParsedCookieMap<K, V> )
 	{
 		const cookie = options instanceof Map ? options : Cookie.parse( options )
 
@@ -205,7 +205,7 @@ export class Cookie
 	 * @param	options The Cookie options.
 	 * @returns	The parsed Cookie Map.
 	 */
-	static parse<K = string, V = string>( options: RawCookie<K, V> ): ParsedCookieMap<K, V>
+	static parse<K = string, V = unknown>( options: RawCookie<K, V> ): ParsedCookieMap<K, V>
 	{
 		const expires	= options.expires ? new Date( options.expires ) : undefined
 		const cookie	= getTypedMap<ParsedCookie<K, V>, false>()
@@ -234,7 +234,7 @@ export class Cookie
 	 * @param	options The cookie options or a parsed Cookie Map.
 	 * @returns	The stringified Cookie ready to be stored.
 	 */
-	static toString<K = string, V = string>( options: RawCookie<K, V> | ParsedCookieMap<K, V> )
+	static toString<K = string, V = unknown>( options: RawCookie<K, V> | ParsedCookieMap<K, V> )
 	{
 		const cookie = options instanceof Map ? options : Cookie.parse( options )
 
@@ -249,8 +249,7 @@ export class Cookie
 		return (
 			[ nameValue, ...values ]
 				.map( ( [ key, value ] ) => {
-					if ( ! key ) return null
-					key = key !== name ? ucFirst( key.toString() ) as K : key
+					key = key !== name ? ucFirst( key!.toString() ) as K : key
 
 					if ( key === 'Expires' && isValidDate( value ) ) {
 						value = value.toUTCString()
@@ -273,7 +272,7 @@ export class Cookie
 	 * @param	cookie The cookie string.
 	 * @returns	The parsed Cookie Map or `null` if parsing fails.
 	 */
-	static fromString<K = string, V = string>( cookie: string ): ParsedCookieMap<K, V> | null
+	static fromString<K = string, V = unknown>( cookie: string ): ParsedCookieMap<K, V> | null
 	{
 		const [ kv, ...rawValues ] = cookie.split( ';' )