Merge pull request #8 from alex-feel/alex-feel-dev

Make setup-python-environment.ps1 compatible with iex execution

Author: alex-feel

scripts/windows/setup-python-environment.ps1

@@ -1,30 +1,10 @@
-<#
-.SYNOPSIS
-    Sets up a complete Python development environment for Claude Code.
+# Claude Code Python Environment Setup for Windows
+# Downloads and configures Python development tools for Claude Code
+# Usage: .\setup-python-environment.ps1 [-SkipInstall] [-Force]
 
-.DESCRIPTION
-    This script installs and configures Claude Code with Python-specific
-    subagents, slash commands, system prompts, and MCP server integration.
-
-    It downloads configuration files from the claude-code-toolbox repository
-    and sets up a launcher script for easy access.
-
-.PARAMETER SkipInstall
-    Skip Claude Code installation (useful if already installed).
-
-.PARAMETER Force
-    Force overwrite of existing configuration files.
-
-.EXAMPLE
-    .\setup-python-environment.ps1
-
-.EXAMPLE
-    .\setup-python-environment.ps1 -SkipInstall
-#>
-
-[Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSReviewUnusedParameter', '', Justification='Parameters are used in conditional logic')]
-[Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUseBOMForUnicodeEncodedFile', '', Justification='UTF-8 without BOM is preferred')]
 [Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSAvoidUsingWriteHost', '', Justification='Installation script needs console output')]
+[Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSAvoidUsingInvokeExpression', '', Justification='Required for remote script execution')]
+[Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSReviewUnusedParameter', '', Justification='Force parameter is used conditionally')]
 param(
     [switch]$SkipInstall,
     [switch]$Force
@@ -64,32 +44,30 @@ $Commands = @(
 # Helper functions
 function Write-Success {
     param([string]$Message)
-    Write-Host "  ✓ $Message" -ForegroundColor Green
+    Write-Host "  OK: $Message" -ForegroundColor Green
 }
 
 function Write-Info {
     param([string]$Message)
-    Write-Host "  ℹ️  $Message" -ForegroundColor Yellow
+    Write-Host "  INFO: $Message" -ForegroundColor Yellow
 }
 
 function Write-Warn {
     param([string]$Message)
-    Write-Host "  ⚠️  $Message" -ForegroundColor Yellow
+    Write-Host "  WARN: $Message" -ForegroundColor Yellow
 }
 
 function Write-ErrorMsg {
     param([string]$Message)
-    Write-Host "  ❌ $Message" -ForegroundColor Red
+    Write-Host "  ERROR: $Message" -ForegroundColor Red
 }
 
 function Write-Header {
-    Write-Host "" # Empty line
-    Write-Host "╔══════════════════════════════════════════════════════════════════════╗" -ForegroundColor Blue
-    Write-Host "║                                                                      ║" -ForegroundColor Blue
-    Write-Host "║     Claude Code Python Environment Setup for Windows                ║" -ForegroundColor Blue
-    Write-Host "║                                                                      ║" -ForegroundColor Blue
-    Write-Host "╚══════════════════════════════════════════════════════════════════════╝" -ForegroundColor Blue
-    Write-Host "" # Empty line
+    Write-Host ""
+    Write-Host "========================================================================" -ForegroundColor Blue
+    Write-Host "     Claude Code Python Environment Setup for Windows                  " -ForegroundColor Blue
+    Write-Host "========================================================================" -ForegroundColor Blue
+    Write-Host ""
 }
 
 function Test-CommandExist {
@@ -130,7 +108,7 @@ function Save-FileFromUrl {
 
     try {
         $response = Invoke-WebRequest -Uri $Url -UseBasicParsing
-        $response.Content | Out-File -FilePath $Destination -Encoding UTF8 -Force
+        [System.IO.File]::WriteAllText($Destination, $response.Content)
         Write-Success "Downloaded: $fileName"
     } catch {
         Write-ErrorMsg "Failed to download: $fileName"
@@ -146,8 +124,9 @@ if (-not $SkipInstall) {
     Write-Host "Step 1: Installing Claude Code..." -ForegroundColor Cyan
 
     try {
-        $installCommand = "iex ((New-Object Net.WebClient).DownloadString('$RepoBaseUrl/scripts/windows/install-claude-windows.ps1'))"
-        powershell -NoProfile -ExecutionPolicy Bypass -Command $installCommand
+        $installUrl = "$RepoBaseUrl/scripts/windows/install-claude-windows.ps1"
+        $installScript = (New-Object Net.WebClient).DownloadString($installUrl)
+        Invoke-Expression $installScript
         Write-Success "Claude Code installation complete"
     } catch {
         Write-ErrorMsg "Failed to install Claude Code"
@@ -167,36 +146,41 @@ if (-not $SkipInstall) {
 }
 
 # Step 2: Create directories
-Write-Host "`nStep 2: Creating configuration directories..." -ForegroundColor Cyan
+Write-Host ""
+Write-Host "Step 2: Creating configuration directories..." -ForegroundColor Cyan
 if (New-DirectoryIfNotExist $ClaudeUserDir) { Write-Success "Created: $ClaudeUserDir" }
 if (New-DirectoryIfNotExist $AgentsDir) { Write-Success "Created: $AgentsDir" }
 if (New-DirectoryIfNotExist $CommandsDir) { Write-Success "Created: $CommandsDir" }
 if (New-DirectoryIfNotExist $PromptsDir) { Write-Success "Created: $PromptsDir" }
 
 # Step 3: Download subagents
-Write-Host "`nStep 3: Downloading Python-optimized subagents..." -ForegroundColor Cyan
+Write-Host ""
+Write-Host "Step 3: Downloading Python-optimized subagents..." -ForegroundColor Cyan
 foreach ($agent in $Agents) {
     $url = "$RepoBaseUrl/agents/examples/$agent.md"
     $destination = Join-Path $AgentsDir "$agent.md"
     Save-FileFromUrl -Url $url -Destination $destination
 }
 
 # Step 4: Download slash commands
-Write-Host "`nStep 4: Downloading slash commands..." -ForegroundColor Cyan
+Write-Host ""
+Write-Host "Step 4: Downloading slash commands..." -ForegroundColor Cyan
 foreach ($command in $Commands) {
     $url = "$RepoBaseUrl/slash-commands/examples/$command.md"
     $destination = Join-Path $CommandsDir "$command.md"
     Save-FileFromUrl -Url $url -Destination $destination
 }
 
 # Step 5: Download Python developer system prompt
-Write-Host "`nStep 5: Downloading Python developer system prompt..." -ForegroundColor Cyan
+Write-Host ""
+Write-Host "Step 5: Downloading Python developer system prompt..." -ForegroundColor Cyan
 $promptUrl = "$RepoBaseUrl/system-prompts/examples/python-developer.md"
 $promptPath = Join-Path $PromptsDir "python-developer.md"
-Download-File -Url $promptUrl -Destination $promptPath
+Save-FileFromUrl -Url $promptUrl -Destination $promptPath
 
 # Step 6: Configure Context7 MCP server
-Write-Host "`nStep 6: Configuring Context7 MCP server..." -ForegroundColor Cyan
+Write-Host ""
+Write-Host "Step 6: Configuring Context7 MCP server..." -ForegroundColor Cyan
 $mcpConfigPath = Join-Path $ClaudeUserDir "mcp.json"
 $mcpConfig = @'
 {
@@ -210,14 +194,15 @@ $mcpConfig = @'
 '@
 
 try {
-    $mcpConfig | Out-File -FilePath $mcpConfigPath -Encoding UTF8 -Force
+    [System.IO.File]::WriteAllText($mcpConfigPath, $mcpConfig)
     Write-Success "Created MCP configuration"
 } catch {
     Write-Warn "Failed to create MCP configuration: $_"
 }
 
 # Step 7: Create launcher script
-Write-Host "`nStep 7: Creating launcher script..." -ForegroundColor Cyan
+Write-Host ""
+Write-Host "Step 7: Creating launcher script..." -ForegroundColor Cyan
 $launcherPath = Join-Path $ClaudeUserDir "start-python-claude.ps1"
 $launcherContent = @'
 # Claude Code Python Environment Launcher
@@ -237,92 +222,91 @@ Write-Host "Starting Claude Code with Python developer configuration..." -Foregr
 '@
 
 try {
-    $launcherContent | Out-File -FilePath $launcherPath -Encoding UTF8 -Force
+    [System.IO.File]::WriteAllText($launcherPath, $launcherContent)
     Write-Success "Created launcher script"
 } catch {
     Write-Warn "Failed to create launcher script: $_"
 }
 
 # Step 8: Register global command
-Write-Host "`nStep 8: Registering global claude-python command..." -ForegroundColor Cyan
+Write-Host ""
+Write-Host "Step 8: Registering global claude-python command..." -ForegroundColor Cyan
 $localBinPath = Join-Path $env:USERPROFILE ".local\bin"
 if (-not (Test-Path $localBinPath)) {
     New-Item -ItemType Directory -Path $localBinPath -Force | Out-Null
 }
 
 # Create batch file for easy execution
 $batchPath = Join-Path $localBinPath "claude-python.cmd"
-# Use single quotes and string concatenation to avoid parser issues with @echo
-$batchContent = '@echo off' + "`r`n" + "powershell -NoProfile -ExecutionPolicy Bypass -File `"$launcherPath`" %*"
-$batchContent | Out-File -FilePath $batchPath -Encoding ASCII
+$batchContent = "@echo off`r`npowershell -NoProfile -ExecutionPolicy Bypass -File `"$launcherPath`" %*"
+[System.IO.File]::WriteAllText($batchPath, $batchContent)
 Write-Success "Created global command: claude-python"
 
 # Add .local\bin to PATH if not already there
-$currentUserPath = [System.Environment]::GetEnvironmentVariable('Path', 'User')
-if ($currentUserPath -notlike "*$localBinPath*") {
-    $newUserPath = "$localBinPath;$currentUserPath"
-    [System.Environment]::SetEnvironmentVariable('Path', $newUserPath, 'User')
+$userPath = [System.Environment]::GetEnvironmentVariable('Path', 'User')
+if (!$userPath) { $userPath = "" }
+if ($userPath -notlike "*$localBinPath*") {
+    if ($userPath -eq "") {
+        [System.Environment]::SetEnvironmentVariable('Path', $localBinPath, 'User')
+    } else {
+        [System.Environment]::SetEnvironmentVariable('Path', "$localBinPath;$userPath", 'User')
+    }
     # Update current session PATH
-    $currentSessionPath = $env:Path
-    $env:Path = "$localBinPath;$currentSessionPath"
+    $sessionPath = $env:Path
+    if (!$sessionPath) { $sessionPath = "" }
+    if ($sessionPath -eq "") {
+        $env:Path = $localBinPath
+    } else {
+        $env:Path = "$localBinPath;$sessionPath"
+    }
     Write-Success "Added $localBinPath to PATH"
     Write-Info "You may need to restart your terminal for PATH changes to take effect"
 }
 
 # Final message
-Write-Host "" # Empty line
-Write-Host "╔══════════════════════════════════════════════════════════════════════╗" -ForegroundColor Green
-Write-Host "║                                                                      ║" -ForegroundColor Green
-Write-Host "║                    ✨ Setup Complete! ✨                            ║" -ForegroundColor Green
-Write-Host "║                                                                      ║" -ForegroundColor Green
-Write-Host "╚══════════════════════════════════════════════════════════════════════╝" -ForegroundColor Green
-Write-Host "" # Empty line
-
-Write-Host "📝 Summary:" -ForegroundColor Yellow
-Write-Host "   • Claude Code installation: " -NoNewline
-if ($SkipInstall) { Write-Host "Skipped" -ForegroundColor Gray } else { Write-Host "Completed" -ForegroundColor Green }
-Write-Host "   • Python subagents: " -NoNewline
-Write-Host "$($Agents.Count) installed" -ForegroundColor Green
-Write-Host "   • Slash commands: " -NoNewline
-Write-Host "$($Commands.Count) installed" -ForegroundColor Green
-Write-Host "   • System prompt: " -NoNewline
-Write-Host "Configured" -ForegroundColor Green
-Write-Host "   • MCP server: " -NoNewline
-Write-Host "Context7 configured" -ForegroundColor Green
-Write-Host "   • Global command: " -NoNewline
-Write-Host "claude-python registered" -ForegroundColor Green
-
-Write-Host "`n🚀 Quick Start:" -ForegroundColor Yellow
-Write-Host "   • Global command: " -NoNewline
-Write-Host "claude-python" -ForegroundColor Cyan
-Write-Host ("   • Full path: & `"" + $launcherPath + "`"")
-Write-Host ("   • Manual: claude --append-system-prompt `"@" + $promptPath + "`"")
-
-Write-Host "`n✨ What's Installed:" -ForegroundColor Yellow
-Write-Host "   • 7 Python-optimized subagents (code review, testing, docs, etc.)"
-Write-Host "   • 6 custom slash commands (/commit, /debug, /test, etc.)"
-Write-Host "   • Context7 MCP server for up-to-date library documentation"
-Write-Host "   • Comprehensive Python development system prompt"
-
-Write-Host "`n📚 Available Commands (after starting Claude):" -ForegroundColor Yellow
-Write-Host "   • " -NoNewline
-Write-Host "/help" -ForegroundColor Cyan -NoNewline
-Write-Host " - See all available commands"
-Write-Host "   • " -NoNewline
-Write-Host "/agents" -ForegroundColor Cyan -NoNewline
-Write-Host " - List available subagents"
-Write-Host "   • " -NoNewline
-Write-Host "/commit" -ForegroundColor Cyan -NoNewline
-Write-Host " - Smart Git commits"
-
-Write-Host "`n💡 Examples:" -ForegroundColor Yellow
-Write-Host "   claude-python" -ForegroundColor Cyan
-Write-Host "   `> Create a FastAPI app with async SQLAlchemy and pytest" -ForegroundColor Gray
 Write-Host ""
-Write-Host "   claude-python" -ForegroundColor Cyan
-Write-Host "   `> /commit fix: resolve database connection pooling issue" -ForegroundColor Gray
+Write-Host "========================================================================" -ForegroundColor Green
+Write-Host "                    Setup Complete!                                    " -ForegroundColor Green
+Write-Host "========================================================================" -ForegroundColor Green
+Write-Host ""
+
+Write-Host "Summary:" -ForegroundColor Yellow
+Write-Host "   * Claude Code installation: $(if ($SkipInstall) { 'Skipped' } else { 'Completed' })"
+Write-Host "   * Python subagents: $($Agents.Count) installed"
+Write-Host "   * Slash commands: $($Commands.Count) installed"
+Write-Host "   * System prompt: Configured"
+Write-Host "   * MCP server: Context7 configured"
+Write-Host "   * Global command: claude-python registered"
+
+Write-Host ""
+Write-Host "Quick Start:" -ForegroundColor Yellow
+Write-Host "   * Global command: claude-python"
+Write-Host "   * Full path: powershell -File '$launcherPath'"
+Write-Host "   * Manual: claude --append-system-prompt '@$promptPath'"
+
+Write-Host ""
+Write-Host "What's Installed:" -ForegroundColor Yellow
+Write-Host "   * 7 Python-optimized subagents (code review, testing, docs, etc.)"
+Write-Host "   * 6 custom slash commands (/commit, /debug, /test, etc.)"
+Write-Host "   * Context7 MCP server for up-to-date library documentation"
+Write-Host "   * Comprehensive Python development system prompt"
 
-Write-Host "`n📖 Documentation:" -ForegroundColor Yellow
-Write-Host "   • Python Setup Guide: https://github.com/alex-feel/claude-code-toolbox/blob/main/docs/python-setup.md"
-Write-Host "   • Claude Code Docs: https://docs.anthropic.com/claude-code"
+Write-Host ""
+Write-Host "Available Commands (after starting Claude):" -ForegroundColor Yellow
+Write-Host "   * /help - See all available commands"
+Write-Host "   * /agents - List available subagents"
+Write-Host "   * /commit - Smart Git commits"
+
+Write-Host ""
+Write-Host "Examples:" -ForegroundColor Yellow
+Write-Host "   claude-python"
+Write-Host "   > Create a FastAPI app with async SQLAlchemy and pytest"
+Write-Host ""
+Write-Host "   claude-python"
+Write-Host "   > /commit fix: resolve database connection pooling issue"
+
+Write-Host ""
+Write-Host "Documentation:" -ForegroundColor Yellow
+Write-Host "   * Python Setup Guide: https://github.com/alex-feel/claude-code-toolbox/blob/main/docs/python-setup.md"
+Write-Host "   * Claude Code Docs: https://docs.anthropic.com/claude-code"
 Write-Host ""