fix: prevent Release Please PRs from blocking due to skipped required checks

Move skip conditions from job level to step level to ensure jobs always
report a status. This fixes the "Expected — Waiting for status to be reported"
issue that blocks Release Please PRs from merging.

Problem:
- When jobs are skipped with job-level if conditions, they don't report any status
- GitHub's required checks wait forever for a status that never comes
- This blocks Release Please PRs even though the checks aren't needed

Solution:
- Jobs always run and report success
- For Release Please PRs, run a simple echo step and skip actual work
- For normal PRs, run all validation steps as usual

Affected jobs:
- PowerShell Script Analysis
- Shell Script Analysis
- Markdown Lint
- JSON/YAML Validation
- Security Scan (Trivy)

This ensures all required checks complete with a success status for Release Please PRs.

Author: alex-feel

.github/workflows/lint.yml

@@ -11,13 +11,18 @@ permissions:
 jobs:
   powershell:
     name: PowerShell Script Analysis
-    if: ${{ ! startsWith(github.head_ref, 'release-please--branches--') }}
     runs-on: windows-latest
 
     steps:
+    - name: Skip for Release Please
+      if: ${{ startsWith(github.head_ref, 'release-please--branches--') }}
+      run: echo "Skipping PowerShell analysis for Release Please PR"
+
     - uses: actions/checkout@v5
+      if: ${{ ! startsWith(github.head_ref, 'release-please--branches--') }}
 
     - name: Run PSScriptAnalyzer
+      if: ${{ ! startsWith(github.head_ref, 'release-please--branches--') }}
       uses: microsoft/psscriptanalyzer-action@v1.1
       with:
         path: ./scripts/windows
@@ -27,19 +32,24 @@ jobs:
 
     - name: Upload PSScriptAnalyzer results
       uses: github/codeql-action/upload-sarif@v3
-      if: always()
+      if: ${{ always() && ! startsWith(github.head_ref, 'release-please--branches--') }}
       with:
         sarif_file: results.sarif
 
   shellcheck:
     name: Shell Script Analysis
-    if: ${{ ! startsWith(github.head_ref, 'release-please--branches--') }}
     runs-on: ubuntu-latest
 
     steps:
+    - name: Skip for Release Please
+      if: ${{ startsWith(github.head_ref, 'release-please--branches--') }}
+      run: echo "Skipping Shell Script analysis for Release Please PR"
+
     - uses: actions/checkout@v5
+      if: ${{ ! startsWith(github.head_ref, 'release-please--branches--') }}
 
     - name: Run ShellCheck
+      if: ${{ ! startsWith(github.head_ref, 'release-please--branches--') }}
       uses: ludeeus/action-shellcheck@master
       with:
         scandir: './scripts'
@@ -48,13 +58,18 @@ jobs:
 
   markdown:
     name: Markdown Lint
-    if: ${{ ! startsWith(github.head_ref, 'release-please--branches--') }}
     runs-on: ubuntu-latest
 
     steps:
+    - name: Skip for Release Please
+      if: ${{ startsWith(github.head_ref, 'release-please--branches--') }}
+      run: echo "Skipping Markdown lint for Release Please PR"
+
     - uses: actions/checkout@v5
+      if: ${{ ! startsWith(github.head_ref, 'release-please--branches--') }}
 
     - name: Run markdownlint
+      if: ${{ ! startsWith(github.head_ref, 'release-please--branches--') }}
       uses: DavidAnson/markdownlint-cli2-action@v20
       with:
         globs: |
@@ -64,13 +79,18 @@ jobs:
 
   json-yaml:
     name: JSON/YAML Validation
-    if: ${{ ! startsWith(github.head_ref, 'release-please--branches--') }}
     runs-on: ubuntu-latest
 
     steps:
+    - name: Skip for Release Please
+      if: ${{ startsWith(github.head_ref, 'release-please--branches--') }}
+      run: echo "Skipping JSON/YAML validation for Release Please PR"
+
     - uses: actions/checkout@v5
+      if: ${{ ! startsWith(github.head_ref, 'release-please--branches--') }}
 
     - name: Validate JSON files
+      if: ${{ ! startsWith(github.head_ref, 'release-please--branches--') }}
       run: |
         find . -name "*.json" -type f -not -path "./node_modules/*" | while read file; do
           echo "Validating $file"
@@ -79,11 +99,13 @@ jobs:
         echo "All JSON files are valid"
 
     - name: Setup Python
+      if: ${{ ! startsWith(github.head_ref, 'release-please--branches--') }}
       uses: actions/setup-python@v5
       with:
         python-version: '3.x'
 
     - name: Validate YAML files
+      if: ${{ ! startsWith(github.head_ref, 'release-please--branches--') }}
       run: |
         pip install pyyaml
         find . -name "*.yml" -o -name "*.yaml" -type f -not -path "./node_modules/*" | while read file; do
@@ -94,13 +116,18 @@ jobs:
 
   security:
     name: Security Scan
-    if: ${{ ! startsWith(github.head_ref, 'release-please--branches--') }}
     runs-on: ubuntu-latest
 
     steps:
+    - name: Skip for Release Please
+      if: ${{ startsWith(github.head_ref, 'release-please--branches--') }}
+      run: echo "Skipping Trivy security scan for Release Please PR"
+
     - uses: actions/checkout@v5
+      if: ${{ ! startsWith(github.head_ref, 'release-please--branches--') }}
 
     - name: Run Trivy security scanner
+      if: ${{ ! startsWith(github.head_ref, 'release-please--branches--') }}
       uses: aquasecurity/trivy-action@master
       with:
         scan-type: 'fs'
@@ -110,6 +137,6 @@ jobs:
 
     - name: Upload Trivy results to GitHub Security
       uses: github/codeql-action/upload-sarif@v3
-      if: always()
+      if: ${{ always() && ! startsWith(github.head_ref, 'release-please--branches--') }}
       with:
         sarif_file: 'trivy-results.sarif'