use a smarter algorithm for integer lengths #557
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
doesn't actually seem faster on our benchmark, but our benchmark is a best case scenario for the old impl: small integer, perfectly predicted size. probably need some benchmarks of random integers |
Owner
Author
|
Current generated code: https://rust.godbolt.org/z/9KMqEs3q3 Will be improved if/when llvm/llvm-project#142869 is landed and makes its way into Rust |
Owner
Author
|
Yes, that implementation looks specifically for big integers, where you
have an arbitrary # of limbs.
…On Tue, Jul 1, 2025 at 5:02 AM dishmaker ***@***.***> wrote:
*dishmaker* left a comment (alex/rust-asn1#557)
<#557 (comment)>
Looks similar to
https://github.com/RustCrypto/crypto-bigint/pull/851/files#diff-87fe87bbce5380197d3c659465e30daf47af5cac570bb4058f467a5b2dffa0b2R68
—
Reply to this email directly, view it on GitHub
<#557 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBBSTFYNDFAD6YLJCTL3GJFEDAVCNFSM6AAAAAB7KGNK7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMRSHAYTQNZYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
All that is necessary for evil to succeed is for good people to do nothing.
|
Owner
Author
|
Looks like the measure is still in the noise. Sadge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.