Skip to content

Commit 8971146

Browse files
authored
Fix unit tests to use os.sep for windows (#117)
1 parent 3a548a6 commit 8971146

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

ask-sdk-s3-persistence-adapter/tests/unit/test_adapter.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import unittest
22

33
import json
4+
import os
45
from boto3.exceptions import ResourceNotExistsError
56
from ask_sdk_model import RequestEnvelope
67
from ask_sdk_core.exceptions import PersistenceException
@@ -101,7 +102,7 @@ def test_get_attributes_from_existing_bucket_get_object_invalid_json_fails(self)
101102
def test_save_attributes_to_existing_bucket(self):
102103
self.object_keygen.return_value = "test_object_key"
103104
json_data = json.dumps(_MOCK_DATA)
104-
generated_key = "test_key/test_object_key"
105+
generated_key = os.path.join("test_key", "test_object_key")
105106

106107
test_s3_adapter = S3Adapter(bucket_name=self.bucket_name, path_prefix=self.bucket_key,
107108
s3_client=self.s3_client, object_keygen=self.object_keygen)
@@ -143,7 +144,7 @@ def test_delete_attributes_to_existing_bucket(self):
143144
self.object_keygen.assert_called_once_with(self.request_envelope)
144145
self.s3_client.delete_object.assert_called_once_with(
145146
Bucket=self.bucket_name,
146-
Key="test_key/test_object_key")
147+
Key=os.path.join("test_key", "test_object_key"))
147148

148149
def test_delete_attributes_to_existing_bucket_delete_object_fails(self):
149150
self.object_keygen.return_value = "test_object_key"

0 commit comments

Comments
 (0)