Fix retrieving commits when more than 10,000

alexandear · alexandear · commit a308cd3e74c9 · 2021-02-06T18:52:26.000+02:00
diff --git a/internal/gitlab/service.go b/internal/gitlab/service.go
@@ -172,6 +172,12 @@ func (s *Service) fetchCommitPage(ctx context.Context, user *pkg.User, page, per
 		commits = append(commits, pkg.NewCommit(*c.CommittedDate, projectID, c.ID))
 	}
 
+	// For performance reasons, if a query returns more than 10,000 records, GitLab
+	// doesn't return TotalPages
+	if resp.TotalPages == 0 {
+		return commits, resp.NextPage, nil
+	}
+
 	if resp.CurrentPage >= resp.TotalPages {
 		return commits, 0, nil
 	}

Original file line number	Diff line number	Diff line change
`@@ -172,6 +172,12 @@ func (s Service) fetchCommitPage(ctx context.Context, user pkg.User, page, per`
`172`	`172`	`commits = append(commits, pkg.NewCommit(*c.CommittedDate, projectID, c.ID))`
`173`	`173`	`}`
`174`	`174`
	`175`	`+ // For performance reasons, if a query returns more than 10,000 records, GitLab`
	`176`	`+ // doesn't return TotalPages`
	`177`	`+ if resp.TotalPages == 0 {`
	`178`	`+ return commits, resp.NextPage, nil`
	`179`	`+ }`
	`180`	`+`
`175`	`181`	`if resp.CurrentPage >= resp.TotalPages {`
`176`	`182`	`return commits, 0, nil`
`177`	`183`	`}`