Do not override payload during transformation error

Author: Alkarex

json-multi-schema-resolver.js

@@ -48,12 +48,11 @@ module.exports = RED => {
 
 		node.on('input', async msg => {
 			delete msg.schemaUrl;
-			msg.error = msg.error ? msg.error + ' ; ' : '';
 			try {
 				const schemaUrl = await resolveAsync(msg.payload);
 				if (schemaUrl != '') {
 					msg.schemaUrl = schemaUrl;
-					msg.error = msg.error != '';
+					msg.error = msg.error ? msg.error : false;
 				}
 				if (lastStatusError) {
 					node.status({ fill:'green', shape:'dot', text:'OK', });
@@ -62,6 +61,7 @@ module.exports = RED => {
 			} catch (ex) {
 				lastStatusError = true;
 				node.status({ fill:'red', shape:'ring', text:'Error', });
+				msg.error = msg.error ? msg.error + ' ; ' : '';
 				msg.error += util.format('Error resolving schema using "%s": %s', mappingsUrl, ex);
 			}
 			node.send(msg);

json-multi-schema-transformer.js

@@ -28,10 +28,6 @@ module.exports = RED => {
 		 * Transform the given payload with the JSONata expression given in URL.
 		 */
 		async function transformAsync(payload, transformUrl) {
-			if (!transformUrl) {
-				return 'Error: Invalid JSONata URL';
-			}
-
 			let jsonataExpression;
 			let jsonataCache = jsonatas[transformUrl];
 			if (jsonataCache) {
@@ -66,7 +62,7 @@ module.exports = RED => {
 
 		node.on('input', async msg => {
 			msg.error = msg.error ? msg.error + ' ; ' : '';
-			if (msg.schemaUrl != '') {
+			if (msg.schemaUrl) {
 				msg.transformUrl = msg.schemaUrl;
 				try {
 					const result = await transformAsync(msg.payload, msg.schemaUrl);
@@ -83,6 +79,7 @@ module.exports = RED => {
 				} catch (ex) {
 					lastStatusError = true;
 					node.status({ fill:'red', shape:'ring', text:'Error', });
+					console.error('Schema2 ' + msg.schemaUrl);
 					msg.error += util.format('Error tranforming using "%s": %s', msg.schemaUrl, ex);
 				}
 			}

json-multi-schema-validator.js

@@ -34,10 +34,6 @@ module.exports = RED => {
 		 * Validate the given payload with the JSON Schema given in URL.
 		 */
 		async function validateAsync(payload, schemaUrl) {
-			if (!schemaUrl) {
-				return 'Error: Invalid JSON schema URL';
-			}
-
 			let validatorCache = validators[schemaUrl];
 			if (validatorCache) {
 				if (validatorCache.validator === null) {
@@ -90,7 +86,7 @@ module.exports = RED => {
 
 		node.on('input', async msg => {
 			msg.error = msg.error ? msg.error + ' ; ' : '';
-			if (msg.schemaUrl != '') {
+			if (msg.schemaUrl) {
 				msg.validUrl = msg.schemaUrl;
 				try {
 					const result = await validateAsync(msg.payload, msg.schemaUrl);

package-lock.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-red-contrib-json-multi-schema",
-	"version": "0.5.1",
+	"version": "0.5.2",
 	"description": "Generic JSON data pipeline tools, with dynamic transformation (using JSONata rules), resolving JSON Schema (using JSONata rules), and then validation (using JSON Schema). For Node-RED and for command-line.",
 	"main": "index.js",
 	"readmeFilename": "readme.md",