Skip to content

Commit fc4b284

Browse files
tedehAlkarex
andauthored
Fixes to the configuration object (#6)
* Fix env configuration type * Required fields in config are no longer required * Remove wonky changing of password attribute * Update postgresql.html Co-authored-by: Alexandre Alapetite <[email protected]>
1 parent c79d6c6 commit fc4b284

File tree

2 files changed

+2
-19
lines changed

2 files changed

+2
-19
lines changed

postgresql.html

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -107,70 +107,60 @@
107107
},
108108
host: {
109109
value: '127.0.0.1',
110-
required: true,
111110
},
112111
hostFieldType: {
113112
value: 'str',
114113
},
115114
port: {
116115
value: 5432,
117-
required: true,
118116
},
119117
portFieldType: {
120118
value: 'num',
121119
},
122120
database: {
123121
value: 'postgres',
124-
required: true,
125122
},
126123
databaseFieldType: {
127124
value: 'str',
128125
},
129126
ssl: {
130127
value: false,
131-
required: true,
132128
},
133129
sslFieldType: {
134130
value: 'bool',
135131
},
136132
max: {
137133
value: 10,
138-
required: true,
139134
},
140135
maxFieldType: {
141136
value: 'num',
142137
},
143138
min: {
144139
value: 1,
145-
required: true,
146140
},
147141
minFieldType: {
148142
value: 'num',
149143
},
150144
idle: {
151145
value: 1000,
152-
required: true,
153146
},
154147
idleFieldType: {
155148
value: 'num',
156149
},
157150
connectionTimeout: {
158151
value: 10000,
159-
required: true,
160152
},
161153
connectionTimeoutFieldType: {
162154
value: 'num',
163155
},
164156
user: {
165157
value: '',
166-
required: true,
167158
},
168159
userFieldType: {
169160
value: 'str',
170161
},
171162
password: {
172163
value: '',
173-
required: true,
174164
},
175165
passwordFieldType: {
176166
value: 'str',
@@ -235,15 +225,6 @@
235225
default: 'str',
236226
types: ['str', 'flow', 'global', 'env'],
237227
typeField: $('#node-config-input-passwordFieldType'),
238-
})
239-
.on('change', function (type, value) {
240-
const e = $(this);
241-
const kind = value === true ? e.typedInput('type') : value;
242-
if (kind === 'str') {
243-
e.attr('type', 'password');
244-
} else {
245-
e.attr('type', 'text');
246-
}
247228
});
248229
$('#node-config-input-max').typedInput({
249230
default: 'num',

postgresql.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ module.exports = function (RED) {
4242
return parseInt(value);
4343
case 'bool':
4444
return JSON.parse(value);
45+
case 'env':
46+
return process.env[value];
4547
default:
4648
return value;
4749
}

0 commit comments

Comments
 (0)