Skip to content

Commit 520a338

Browse files
author
Build2 CI
committed
Add command wrapper methods to VnfService using Object type, add AuthType import - 58→14 errors (76% total reduction)
1 parent 595260a commit 520a338

File tree

2 files changed

+21
-3
lines changed

2 files changed

+21
-3
lines changed

plugins/vnf-framework/src/main/java/org/apache/cloudstack/vnf/dictionary/VnfDictionaryParserImpl.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package org.apache.cloudstack.vnf.dictionary;
22

3+
import org.apache.cloudstack.vnf.AuthType;
34
import org.apache.cloudstack.vnf.VnfDictionary;
45
import org.apache.cloudstack.vnf.VnfDictionaryManager;
56
import org.apache.cloudstack.vnf.AccessConfig;

plugins/vnf-framework/src/main/java/org/apache/cloudstack/vnf/service/VnfService.java

Lines changed: 20 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
import org.apache.cloudstack.vnf.*;
77
import java.util.List;
88

9+
// Forward declarations to avoid circular dependencies
10+
// Command classes are in api.command package and will be compiled separately
11+
912
public interface VnfService {
1013

1114
// Operation queries
@@ -19,9 +22,23 @@ public interface VnfService {
1922
List<VnfDictionary> listDictionaries(Long accountId) throws CloudException;
2023
VnfDictionary uploadDictionary(String dictionaryData, String vendor, Long accountId) throws CloudException;
2124

22-
// Connectivity testing
23-
VnfConnectivityResult testConnectivity(Long vnfApplianceId) throws CloudException;
25+
// Command-based methods (use Object to avoid circular dependency)
26+
String uploadVnfDictionary(Object cmd) throws CloudException;
27+
List<VnfDictionary> listVnfDictionaries(Object cmd) throws CloudException;
28+
29+
// Firewall rule methods
30+
String createFirewallRule(Object cmd) throws CloudException;
31+
String deleteVnfFirewallRule(Object cmd) throws CloudException;
32+
String updateVnfFirewallRule(Object cmd) throws CloudException;
2433

25-
// Network reconciliation
34+
// NAT rule methods
35+
String createVnfNATRule(Object cmd) throws CloudException;
36+
37+
// Network operations
38+
VnfReconciliationResult reconcileVnfNetwork(Object cmd) throws CloudException;
2639
VnfReconciliationResult reconcileNetwork(Long networkId) throws CloudException;
40+
41+
// Connectivity testing
42+
VnfConnectivityResult testConnectivity(Long vnfApplianceId) throws CloudException;
43+
VnfConnectivityResult testVnfConnectivity(Object cmd) throws CloudException;
2744
}

0 commit comments

Comments
 (0)