Skip to content

Commit ab2b18c

Browse files
author
Build2 CI
committed
Add missing setters to VnfDictionary and AccessConfig, update VnfService with state-based queries, fix Logger calls
1 parent 6730888 commit ab2b18c

File tree

5 files changed

+38
-2
lines changed

5 files changed

+38
-2
lines changed

plugins/vnf-framework/src/main/java/org/apache/cloudstack/vnf/AccessConfig.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,16 @@ public class AccessConfig {
1616
public void setPort(int port) { this.port = port; }
1717
public AuthType getAuthType() { return authType; }
1818
public void setAuthType(AuthType authType) { this.authType = authType; }
19+
public String getBasePath() { return basePath; }
20+
public void setBasePath(String basePath) { this.basePath = basePath; }
21+
public String getUsernameRef() { return usernameRef; }
22+
public void setUsernameRef(String usernameRef) { this.usernameRef = usernameRef; }
23+
public String getPasswordRef() { return passwordRef; }
24+
public void setPasswordRef(String passwordRef) { this.passwordRef = passwordRef; }
25+
public String getTokenRef() { return tokenRef; }
26+
public void setTokenRef(String tokenRef) { this.tokenRef = tokenRef; }
27+
public String getTokenHeader() { return tokenHeader; }
28+
public void setTokenHeader(String tokenHeader) { this.tokenHeader = tokenHeader; }
1929
}
2030
/**
2131
* Service definition (e.g., Firewall, NAT)

plugins/vnf-framework/src/main/java/org/apache/cloudstack/vnf/VnfDictionary.java

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,24 @@ public class VnfDictionary {
2727
public void setAccessConfig(AccessConfig config) { this.accessConfig = config; }
2828
public Map<String, ServiceDefinition> getServices() { return services; }
2929
public void setServices(Map<String, ServiceDefinition> services) { this.services = services; }
30+
public String getUuid() { return uuid; }
31+
public void setUuid(String uuid) { this.uuid = uuid; }
32+
public Long getTemplateId() { return templateId; }
33+
public void setTemplateId(Long templateId) { this.templateId = templateId; }
34+
public Long getNetworkId() { return networkId; }
35+
public void setNetworkId(Long networkId) { this.networkId = networkId; }
36+
public String getName() { return name; }
37+
public void setName(String name) { this.name = name; }
38+
public String getYamlContent() { return yamlContent; }
39+
public void setYamlContent(String yamlContent) { this.yamlContent = yamlContent; }
40+
public String getVendor() { return vendor; }
41+
public void setVendor(String vendor) { this.vendor = vendor; }
42+
public String getProduct() { return product; }
43+
public void setProduct(String product) { this.product = product; }
44+
public Date getCreated() { return created; }
45+
public void setCreated(Date created) { this.created = created; }
46+
public Date getUpdated() { return updated; }
47+
public void setUpdated(Date updated) { this.updated = updated; }
3048
public ServiceDefinition getService(String name) { return services.get(name); }
3149
}
3250
/**

plugins/vnf-framework/src/main/java/org/apache/cloudstack/vnf/VnfService.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
import com.cloud.exception.CloudException;
44
import org.apache.cloudstack.vnf.dao.VnfOperationVO;
5+
import org.apache.cloudstack.vnf.dao.VnfOperationVO.State;
6+
import org.apache.cloudstack.vnf.api.command.UploadVnfDictionaryCmd;
57
import java.util.List;
68

79
public interface VnfService {
@@ -10,12 +12,18 @@ public interface VnfService {
1012

1113
List<VnfOperationVO> listOperationsByVnfInstance(Long vnfInstanceId) throws CloudException;
1214

15+
List<VnfOperationVO> listOperationsByVnfInstanceAndState(Long vnfInstanceId, State state) throws CloudException;
16+
17+
List<VnfOperationVO> listOperationsByState(State state) throws CloudException;
18+
1319
List<VnfOperationVO> listAllOperations(Long startIndex, Long pageSize) throws CloudException;
1420

1521
List<VnfDictionary> listDictionaries(Long accountId) throws CloudException;
1622

1723
VnfDictionary uploadDictionary(String dictionaryData, String vendor, Long accountId) throws CloudException;
1824

25+
VnfDictionary uploadVnfDictionary(UploadVnfDictionaryCmd cmd) throws CloudException;
26+
1927
VnfConnectivityResult testConnectivity(Long vnfApplianceId) throws CloudException;
2028

2129
VnfReconciliationResult reconcileNetwork(Long networkId) throws CloudException;

plugins/vnf-framework/src/main/java/org/apache/cloudstack/vnf/client/VnfBrokerClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
* Client for communicating with the VNF Broker service running on Virtual Router
2020
*/
2121
public class VnfBrokerClient {
22-
private static final Logger LOGGER = Logger.getLogger(VnfBrokerClient.class);
22+
private static final Logger LOGGER = LogManager.getLogger(VnfBrokerClient.class);
2323
private static final ObjectMapper objectMapper = new ObjectMapper();
2424

2525
private final String brokerUrl;

plugins/vnf-framework/src/main/java/org/apache/cloudstack/vnf/provider/VnfNetworkElement.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
* Enables CloudStack to apply network rules to VNF appliances
3434
*/
3535
public class VnfNetworkElement implements NetworkElement, FirewallServiceProvider {
36-
private static final Logger LOGGER = Logger.getLogger(VnfNetworkElement.class);
36+
private static final Logger LOGGER = LogManager.getLogger(VnfNetworkElement.class);
3737

3838
@Inject
3939
private VnfInstanceDao vnfInstanceDao;

0 commit comments

Comments
 (0)