Remove mut to all getopt functions (#507)

* Use CURLOPT_TIMEOUT if timeout too big

If the time that was converted into millisecond
is more than the capacity of c_long, it will
overflow, thus we need to convert it into seconds
and use CURLOPT_TIMEOUT.

* Remove mut to all getopt functions

There is no mutation involve when calling
getopt functions.

Author: LorenzoLeonardo

src/easy/handler.rs

@@ -2727,7 +2727,7 @@ impl<H> Easy2<H> {
     // /// Fetches this handle's private pointer-sized piece of data.
     // ///
     // /// This corresponds to `CURLINFO_PRIVATE` and defaults to 0.
-    // pub fn private(&mut self) -> Result<usize, Error> {
+    // pub fn private(&self) -> Result<usize, Error> {
     //     self.getopt_ptr(curl_sys::CURLINFO_PRIVATE).map(|p| p as usize)
     // }
 
@@ -2767,7 +2767,7 @@ impl<H> Easy2<H> {
     ///
     //// This corresponds to `CURLINFO_CONDITION_UNMET` and may return an error if the
     /// option is not supported
-    pub fn time_condition_unmet(&mut self) -> Result<bool, Error> {
+    pub fn time_condition_unmet(&self) -> Result<bool, Error> {
         self.getopt_long(curl_sys::CURLINFO_CONDITION_UNMET)
             .map(|r| r != 0)
     }
@@ -2781,7 +2781,7 @@ impl<H> Easy2<H> {
     ///
     /// Returns `Ok(None)` if no effective url is listed or `Err` if an error
     /// happens or the underlying bytes aren't valid utf-8.
-    pub fn effective_url(&mut self) -> Result<Option<&str>, Error> {
+    pub fn effective_url(&self) -> Result<Option<&str>, Error> {
         self.getopt_str(curl_sys::CURLINFO_EFFECTIVE_URL)
     }
 
@@ -2794,7 +2794,7 @@ impl<H> Easy2<H> {
     ///
     /// Returns `Ok(None)` if no effective url is listed or `Err` if an error
     /// happens or the underlying bytes aren't valid utf-8.
-    pub fn effective_url_bytes(&mut self) -> Result<Option<&[u8]>, Error> {
+    pub fn effective_url_bytes(&self) -> Result<Option<&[u8]>, Error> {
         self.getopt_bytes(curl_sys::CURLINFO_EFFECTIVE_URL)
     }
 
@@ -2806,7 +2806,7 @@ impl<H> Easy2<H> {
     ///
     /// Corresponds to `CURLINFO_RESPONSE_CODE` and returns an error if this
     /// option is not supported.
-    pub fn response_code(&mut self) -> Result<u32, Error> {
+    pub fn response_code(&self) -> Result<u32, Error> {
         self.getopt_long(curl_sys::CURLINFO_RESPONSE_CODE)
             .map(|c| c as u32)
     }
@@ -2818,7 +2818,7 @@ impl<H> Easy2<H> {
     ///
     /// Corresponds to `CURLINFO_HTTP_CONNECTCODE` and returns an error if this
     /// option is not supported.
-    pub fn http_connectcode(&mut self) -> Result<u32, Error> {
+    pub fn http_connectcode(&self) -> Result<u32, Error> {
         self.getopt_long(curl_sys::CURLINFO_HTTP_CONNECTCODE)
             .map(|c| c as u32)
     }
@@ -2837,7 +2837,7 @@ impl<H> Easy2<H> {
     ///
     /// This corresponds to `CURLINFO_FILETIME` and may return an error if the
     /// option is not supported
-    pub fn filetime(&mut self) -> Result<Option<i64>, Error> {
+    pub fn filetime(&self) -> Result<Option<i64>, Error> {
         self.getopt_long(curl_sys::CURLINFO_FILETIME).map(|r| {
             if r == -1 {
                 None
@@ -2856,7 +2856,7 @@ impl<H> Easy2<H> {
     ///
     /// This corresponds to `CURLINFO_SIZE_DOWNLOAD` and may return an error if the
     /// option is not supported
-    pub fn download_size(&mut self) -> Result<f64, Error> {
+    pub fn download_size(&self) -> Result<f64, Error> {
         self.getopt_double(curl_sys::CURLINFO_SIZE_DOWNLOAD)
             .map(|r| r as f64)
     }
@@ -2867,7 +2867,7 @@ impl<H> Easy2<H> {
     ///
     /// This corresponds to `CURLINFO_SIZE_UPLOAD` and may return an error if the
     /// option is not supported
-    pub fn upload_size(&mut self) -> Result<f64, Error> {
+    pub fn upload_size(&self) -> Result<f64, Error> {
         self.getopt_double(curl_sys::CURLINFO_SIZE_UPLOAD)
             .map(|r| r as f64)
     }
@@ -2879,7 +2879,7 @@ impl<H> Easy2<H> {
     ///
     /// This corresponds to `CURLINFO_CONTENT_LENGTH_DOWNLOAD` and may return an error if the
     /// option is not supported
-    pub fn content_length_download(&mut self) -> Result<f64, Error> {
+    pub fn content_length_download(&self) -> Result<f64, Error> {
         self.getopt_double(curl_sys::CURLINFO_CONTENT_LENGTH_DOWNLOAD)
             .map(|r| r as f64)
     }
@@ -2891,7 +2891,7 @@ impl<H> Easy2<H> {
     ///
     /// Corresponds to `CURLINFO_TOTAL_TIME` and may return an error if the
     /// option isn't supported.
-    pub fn total_time(&mut self) -> Result<Duration, Error> {
+    pub fn total_time(&self) -> Result<Duration, Error> {
         self.getopt_double(curl_sys::CURLINFO_TOTAL_TIME)
             .map(double_seconds_to_duration)
     }
@@ -2903,7 +2903,7 @@ impl<H> Easy2<H> {
     ///
     /// Corresponds to `CURLINFO_NAMELOOKUP_TIME` and may return an error if the
     /// option isn't supported.
-    pub fn namelookup_time(&mut self) -> Result<Duration, Error> {
+    pub fn namelookup_time(&self) -> Result<Duration, Error> {
         self.getopt_double(curl_sys::CURLINFO_NAMELOOKUP_TIME)
             .map(double_seconds_to_duration)
     }
@@ -2915,7 +2915,7 @@ impl<H> Easy2<H> {
     ///
     /// Corresponds to `CURLINFO_CONNECT_TIME` and may return an error if the
     /// option isn't supported.
-    pub fn connect_time(&mut self) -> Result<Duration, Error> {
+    pub fn connect_time(&self) -> Result<Duration, Error> {
         self.getopt_double(curl_sys::CURLINFO_CONNECT_TIME)
             .map(double_seconds_to_duration)
     }
@@ -2930,7 +2930,7 @@ impl<H> Easy2<H> {
     ///
     /// Corresponds to `CURLINFO_APPCONNECT_TIME` and may return an error if the
     /// option isn't supported.
-    pub fn appconnect_time(&mut self) -> Result<Duration, Error> {
+    pub fn appconnect_time(&self) -> Result<Duration, Error> {
         self.getopt_double(curl_sys::CURLINFO_APPCONNECT_TIME)
             .map(double_seconds_to_duration)
     }
@@ -2945,7 +2945,7 @@ impl<H> Easy2<H> {
     ///
     /// Corresponds to `CURLINFO_PRETRANSFER_TIME` and may return an error if the
     /// option isn't supported.
-    pub fn pretransfer_time(&mut self) -> Result<Duration, Error> {
+    pub fn pretransfer_time(&self) -> Result<Duration, Error> {
         self.getopt_double(curl_sys::CURLINFO_PRETRANSFER_TIME)
             .map(double_seconds_to_duration)
     }
@@ -2958,7 +2958,7 @@ impl<H> Easy2<H> {
     ///
     /// Corresponds to `CURLINFO_STARTTRANSFER_TIME` and may return an error if the
     /// option isn't supported.
-    pub fn starttransfer_time(&mut self) -> Result<Duration, Error> {
+    pub fn starttransfer_time(&self) -> Result<Duration, Error> {
         self.getopt_double(curl_sys::CURLINFO_STARTTRANSFER_TIME)
             .map(double_seconds_to_duration)
     }
@@ -2972,7 +2972,7 @@ impl<H> Easy2<H> {
     ///
     /// Corresponds to `CURLINFO_REDIRECT_TIME` and may return an error if the
     /// option isn't supported.
-    pub fn redirect_time(&mut self) -> Result<Duration, Error> {
+    pub fn redirect_time(&self) -> Result<Duration, Error> {
         self.getopt_double(curl_sys::CURLINFO_REDIRECT_TIME)
             .map(double_seconds_to_duration)
     }
@@ -2981,7 +2981,7 @@ impl<H> Easy2<H> {
     ///
     /// Corresponds to `CURLINFO_REDIRECT_COUNT` and may return an error if the
     /// option isn't supported.
-    pub fn redirect_count(&mut self) -> Result<u32, Error> {
+    pub fn redirect_count(&self) -> Result<u32, Error> {
         self.getopt_long(curl_sys::CURLINFO_REDIRECT_COUNT)
             .map(|c| c as u32)
     }
@@ -2996,7 +2996,7 @@ impl<H> Easy2<H> {
     ///
     /// Corresponds to `CURLINFO_REDIRECT_URL` and may return an error if the
     /// url isn't valid utf-8 or an error happens.
-    pub fn redirect_url(&mut self) -> Result<Option<&str>, Error> {
+    pub fn redirect_url(&self) -> Result<Option<&str>, Error> {
         self.getopt_str(curl_sys::CURLINFO_REDIRECT_URL)
     }
 
@@ -3009,15 +3009,15 @@ impl<H> Easy2<H> {
     /// URL.
     ///
     /// Corresponds to `CURLINFO_REDIRECT_URL` and may return an error.
-    pub fn redirect_url_bytes(&mut self) -> Result<Option<&[u8]>, Error> {
+    pub fn redirect_url_bytes(&self) -> Result<Option<&[u8]>, Error> {
         self.getopt_bytes(curl_sys::CURLINFO_REDIRECT_URL)
     }
 
     /// Get size of retrieved headers
     ///
     /// Corresponds to `CURLINFO_HEADER_SIZE` and may return an error if the
     /// option isn't supported.
-    pub fn header_size(&mut self) -> Result<u64, Error> {
+    pub fn header_size(&self) -> Result<u64, Error> {
         self.getopt_long(curl_sys::CURLINFO_HEADER_SIZE)
             .map(|c| c as u64)
     }
@@ -3026,7 +3026,7 @@ impl<H> Easy2<H> {
     ///
     /// Corresponds to `CURLINFO_REQUEST_SIZE` and may return an error if the
     /// option isn't supported.
-    pub fn request_size(&mut self) -> Result<u64, Error> {
+    pub fn request_size(&self) -> Result<u64, Error> {
         self.getopt_long(curl_sys::CURLINFO_REQUEST_SIZE)
             .map(|c| c as u64)
     }
@@ -3040,7 +3040,7 @@ impl<H> Easy2<H> {
     ///
     /// Corresponds to `CURLINFO_CONTENT_TYPE` and may return an error if the
     /// option isn't supported.
-    pub fn content_type(&mut self) -> Result<Option<&str>, Error> {
+    pub fn content_type(&self) -> Result<Option<&str>, Error> {
         self.getopt_str(curl_sys::CURLINFO_CONTENT_TYPE)
     }
 
@@ -3053,7 +3053,7 @@ impl<H> Easy2<H> {
     ///
     /// Corresponds to `CURLINFO_CONTENT_TYPE` and may return an error if the
     /// option isn't supported.
-    pub fn content_type_bytes(&mut self) -> Result<Option<&[u8]>, Error> {
+    pub fn content_type_bytes(&self) -> Result<Option<&[u8]>, Error> {
         self.getopt_bytes(curl_sys::CURLINFO_CONTENT_TYPE)
     }
 
@@ -3064,7 +3064,7 @@ impl<H> Easy2<H> {
     ///
     /// Corresponds to `CURLINFO_OS_ERRNO` and may return an error if the
     /// option isn't supported.
-    pub fn os_errno(&mut self) -> Result<i32, Error> {
+    pub fn os_errno(&self) -> Result<i32, Error> {
         self.getopt_long(curl_sys::CURLINFO_OS_ERRNO)
             .map(|c| c as i32)
     }
@@ -3077,15 +3077,15 @@ impl<H> Easy2<H> {
     ///
     /// Corresponds to `CURLINFO_PRIMARY_IP` and may return an error if the
     /// option isn't supported.
-    pub fn primary_ip(&mut self) -> Result<Option<&str>, Error> {
+    pub fn primary_ip(&self) -> Result<Option<&str>, Error> {
         self.getopt_str(curl_sys::CURLINFO_PRIMARY_IP)
     }
 
     /// Get the latest destination port number
     ///
     /// Corresponds to `CURLINFO_PRIMARY_PORT` and may return an error if the
     /// option isn't supported.
-    pub fn primary_port(&mut self) -> Result<u16, Error> {
+    pub fn primary_port(&self) -> Result<u16, Error> {
         self.getopt_long(curl_sys::CURLINFO_PRIMARY_PORT)
             .map(|c| c as u16)
     }
@@ -3098,15 +3098,15 @@ impl<H> Easy2<H> {
     ///
     /// Corresponds to `CURLINFO_LOCAL_IP` and may return an error if the
     /// option isn't supported.
-    pub fn local_ip(&mut self) -> Result<Option<&str>, Error> {
+    pub fn local_ip(&self) -> Result<Option<&str>, Error> {
         self.getopt_str(curl_sys::CURLINFO_LOCAL_IP)
     }
 
     /// Get the latest local port number
     ///
     /// Corresponds to `CURLINFO_LOCAL_PORT` and may return an error if the
     /// option isn't supported.
-    pub fn local_port(&mut self) -> Result<u16, Error> {
+    pub fn local_port(&self) -> Result<u16, Error> {
         self.getopt_long(curl_sys::CURLINFO_LOCAL_PORT)
             .map(|c| c as u16)
     }
@@ -3426,7 +3426,7 @@ impl<H> Easy2<H> {
         unsafe { self.cvt(curl_sys::curl_easy_setopt(self.inner.handle, opt, blob_ptr)) }
     }
 
-    fn getopt_bytes(&mut self, opt: curl_sys::CURLINFO) -> Result<Option<&[u8]>, Error> {
+    fn getopt_bytes(&self, opt: curl_sys::CURLINFO) -> Result<Option<&[u8]>, Error> {
         unsafe {
             let p = self.getopt_ptr(opt)?;
             if p.is_null() {
@@ -3437,7 +3437,7 @@ impl<H> Easy2<H> {
         }
     }
 
-    fn getopt_ptr(&mut self, opt: curl_sys::CURLINFO) -> Result<*const c_char, Error> {
+    fn getopt_ptr(&self, opt: curl_sys::CURLINFO) -> Result<*const c_char, Error> {
         unsafe {
             let mut p = ptr::null();
             let rc = curl_sys::curl_easy_getinfo(self.inner.handle, opt, &mut p);
@@ -3446,7 +3446,7 @@ impl<H> Easy2<H> {
         }
     }
 
-    fn getopt_str(&mut self, opt: curl_sys::CURLINFO) -> Result<Option<&str>, Error> {
+    fn getopt_str(&self, opt: curl_sys::CURLINFO) -> Result<Option<&str>, Error> {
         match self.getopt_bytes(opt) {
             Ok(None) => Ok(None),
             Err(e) => Err(e),
@@ -3457,7 +3457,7 @@ impl<H> Easy2<H> {
         }
     }
 
-    fn getopt_long(&mut self, opt: curl_sys::CURLINFO) -> Result<c_long, Error> {
+    fn getopt_long(&self, opt: curl_sys::CURLINFO) -> Result<c_long, Error> {
         unsafe {
             let mut p = 0;
             let rc = curl_sys::curl_easy_getinfo(self.inner.handle, opt, &mut p);
@@ -3466,7 +3466,7 @@ impl<H> Easy2<H> {
         }
     }
 
-    fn getopt_double(&mut self, opt: curl_sys::CURLINFO) -> Result<c_double, Error> {
+    fn getopt_double(&self, opt: curl_sys::CURLINFO) -> Result<c_double, Error> {
         unsafe {
             let mut p = 0 as c_double;
             let rc = curl_sys::curl_easy_getinfo(self.inner.handle, opt, &mut p);