fix: require container arguments for kill, stop, and rm (#290)

Fixes #129

- kill, stop, and rm commands now return clear error when no container arguments provided
- Added unit tests for argument validation
- Added integration tests for missing-argument errors

Co-authored-by: Marvin <marvin@openclaw.ai>

Author: alexei-led

docs/guide.md

@@ -58,7 +58,7 @@ pumba --random kill "re2:^test"
 
 ## Container Chaos Commands
 
-Each command targets containers using the [targeting methods](#container-targeting) described above. Run `pumba <command> --help` for the full list of options.
+Each command targets containers using the [targeting methods](#container-targeting) described above. Run `pumba <command> --help` for the full list of options. The `kill`, `stop`, and `rm` commands require at least one container argument (name, list of names, or RE2 regex).
 
 ### kill
 

pkg/chaos/docker/cmd/commands_test.go

@@ -0,0 +1,38 @@
+package cmd
+
+import (
+	"context"
+	"flag"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/urfave/cli"
+)
+
+func newTestCLIContext(args []string) *cli.Context {
+	app := cli.NewApp()
+	fs := flag.NewFlagSet("test", flag.ContinueOnError)
+	_ = fs.Parse(args)
+	return cli.NewContext(app, fs, nil)
+}
+
+func TestKillRequiresContainerArgument(t *testing.T) {
+	cmd := &killContext{context: context.Background()}
+	c := newTestCLIContext(nil)
+	err := cmd.kill(c)
+	assert.EqualError(t, err, "container name, list of names, or RE2 regex is required")
+}
+
+func TestStopRequiresContainerArgument(t *testing.T) {
+	cmd := &stopContext{context: context.Background()}
+	c := newTestCLIContext(nil)
+	err := cmd.stop(c)
+	assert.EqualError(t, err, "container name, list of names, or RE2 regex is required")
+}
+
+func TestRemoveRequiresContainerArgument(t *testing.T) {
+	cmd := &removeContext{context: context.Background()}
+	c := newTestCLIContext(nil)
+	err := cmd.remove(c)
+	assert.EqualError(t, err, "container name, list of names, or RE2 regex is required")
+}

pkg/chaos/docker/cmd/kill.go

@@ -39,6 +39,9 @@ func NewKillCLICommand(ctx context.Context) *cli.Command {
 
 // KILL Command
 func (cmd *killContext) kill(c *cli.Context) error {
+	if !c.Args().Present() {
+		return fmt.Errorf("container name, list of names, or RE2 regex is required")
+	}
 	// parse common chaos flags
 	params, err := chaos.ParseGlobalParams(c)
 	if err != nil {

pkg/chaos/docker/cmd/remove.go

@@ -46,6 +46,9 @@ func NewRemoveCLICommand(ctx context.Context) *cli.Command {
 
 // REMOVE Command
 func (cmd *removeContext) remove(c *cli.Context) error {
+	if !c.Args().Present() {
+		return fmt.Errorf("container name, list of names, or RE2 regex is required")
+	}
 	// parse common chaos flags
 	params, err := chaos.ParseGlobalParams(c)
 	if err != nil {

pkg/chaos/docker/cmd/stop.go

@@ -49,6 +49,9 @@ func NewStopCLICommand(ctx context.Context) *cli.Command {
 
 // STOP Command
 func (cmd *stopContext) stop(c *cli.Context) error {
+	if !c.Args().Present() {
+		return fmt.Errorf("container name, list of names, or RE2 regex is required")
+	}
 	// parse common chaos flags
 	params, err := chaos.ParseGlobalParams(c)
 	if err != nil {

tests/error_handling.bats

@@ -148,6 +148,27 @@ teardown() {
     [ $status -eq 0 ]
 }
 
+@test "Should fail when kill command has no container arguments" {
+    run pumba kill
+
+    [ $status -ne 0 ]
+    [[ $output =~ "container name, list of names, or RE2 regex is required" ]]
+}
+
+@test "Should fail when stop command has no container arguments" {
+    run pumba stop
+
+    [ $status -ne 0 ]
+    [[ $output =~ "container name, list of names, or RE2 regex is required" ]]
+}
+
+@test "Should fail when rm command has no container arguments" {
+    run pumba rm
+
+    [ $status -ne 0 ]
+    [[ $output =~ "container name, list of names, or RE2 regex is required" ]]
+}
+
 @test "Should handle CIDR notation formats" {
     # This test skips actual execution since we're just testing CLI parsing
     run pumba iptables --help