You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: AGENTS.md
+9-2Lines changed: 9 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -70,6 +70,8 @@ Add a test function in `pkg/get/get_test.go`. **Reference `Test_DownloadFaasCli`
70
70
71
71
### Step 4: Download and Verify Every OS/Arch Combination
72
72
73
+
First test downloading the current OS/arch (no flags needed) i.e. `go run . get TOOL`. And run `file` on the output to verify the type and if it's valid or invalid i.e. a gzip, or a HTML page, or got a non zero exit code.
74
+
73
75
**MANDATORY**: Download and verify EVERY combination using the `file` command.
74
76
75
77
```bash
@@ -87,13 +89,18 @@ For each combination, verify the `file` command output:
87
89
- Darwin arm64: `Mach-O 64-bit arm64 executable`
88
90
- Windows amd64: `PE32+ executable (console) x86-64`
89
91
90
-
Tools built with rust have `unknown` in their filename, that's OK. If deciding between GNU aka libc or musl, pick the non-musl version.
92
+
Tools built with Rust often have `unknown` in their filename, that's OK. If deciding between GNU aka libc or musl, pick the non-musl version, it might be named "unknown".
91
93
92
94
**Include the full output of `./hack/test-tool.sh TOOL_NAME` in your PR description.**
93
95
94
96
### Step 5: Update Documentation
95
97
96
-
The README.md file contains instructions for updating itself. Follow the note at the bottom of the "Catalog of CLIs" section: run `go build && ./arkade get --format markdown` to generate the updated table, then replace the existing catalog section.
98
+
The README.md file contains instructions for updating itself. Follow the note at the bottom of the "Catalog of CLIs" section: run `go run . get --format markdown` to generate the updated table, then replace the existing catalog section. Write it to a file in the workspace that you delete after, to avoid needing extra permissions.
99
+
100
+
There are two tokens in the README.md - replace al text between them with what you've generated.
101
+
102
+
Start of replaceable block is inside: `<!-- start of tool list -->` and the end is inside: `<!-- end of tool list -->`.
0 commit comments