Skip to content

Commit 07a236e

Browse files
Fixes to make PostImageScriptTest pass
1 parent bd9f9cb commit 07a236e

File tree

2 files changed

+15
-3
lines changed

2 files changed

+15
-3
lines changed

src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacPackagingPipeline.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,8 @@ static PackagingPipeline.Builder build(Optional<Package> pkg) {
107107
return new TaskContextProxy(appContext, false, isRuntimeInstaller || withPredefinedAppImage);
108108
})
109109
.appImageLayoutForPackaging(MacPackagingPipeline::packagingLayout)
110+
.task(PackageTaskID.RUN_POST_IMAGE_USER_SCRIPT)
111+
.packageAction(MacPackagingPipeline::runPostAppImageUserScript).add()
110112
.task(CopyAppImageTaskID.COPY)
111113
.copyAction(MacPackagingPipeline::copyAppImage).add()
112114
.task(MacBuildApplicationTaskID.RUNTIME_INFO_PLIST)
@@ -217,6 +219,12 @@ private static void copyJliLib(
217219
}
218220
}
219221

222+
private static void runPostAppImageUserScript(PackageBuildEnv<Package, AppImageLayout> env) throws IOException {
223+
PackagingPipeline.runPostAppImageUserScript(new PackageBuildEnv<>(
224+
BuildEnv.withAppImageDir(env.env(), env.env().appImageDir().resolve(env.envLayout().rootDirectory())),
225+
env.pkg(), env.pkg().appImageLayout(), env.outputDir()));
226+
}
227+
220228
private static void writePackageFile(PackageBuildEnv<Package, ApplicationLayout> env) throws IOException {
221229
new PackageFile(env.pkg().packageName()).save(env.resolvedLayout());
222230
}

src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacPkgPackager.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -235,12 +235,15 @@ private void applyToPipeline(PackagingPipeline.Builder pipelineBuilder) {
235235
.excludeDirFromCopying(outputDir)
236236
.task(PkgPackageTaskID.PREPARE_MAIN_SCRIPTS)
237237
.action(this::prepareMainScripts)
238+
.addDependent(PackageTaskID.RUN_POST_IMAGE_USER_SCRIPT)
238239
.add()
239240
.task(PkgPackageTaskID.CREATE_DISTRIBUTION_XML_FILE)
240241
.action(this::prepareDistributionXMLFile)
242+
.addDependent(PackageTaskID.RUN_POST_IMAGE_USER_SCRIPT)
241243
.add()
242244
.task(PkgPackageTaskID.CREATE_COMPONENT_PLIST_FILE)
243245
.action(this::createComponentPlistFile)
246+
.addDependent(PackageTaskID.RUN_POST_IMAGE_USER_SCRIPT)
244247
.add()
245248
.task(PackageTaskID.CREATE_CONFIG_FILES)
246249
.action(this::prepareConfigFiles)
@@ -252,18 +255,19 @@ private void applyToPipeline(PackagingPipeline.Builder pipelineBuilder) {
252255
.add()
253256
.task(PkgPackageTaskID.PREPARE_SERVICES)
254257
.action(this::prepareServicesForBkgbuild)
258+
.addDependent(PackageTaskID.RUN_POST_IMAGE_USER_SCRIPT)
255259
.add()
256260
.task(InternalPackageType.SERVICES)
257-
.addDependencies(PkgPackageTaskID.PREPARE_SERVICES)
258261
.action(this::buildServicesPKG)
262+
.addDependencies(PkgPackageTaskID.PREPARE_SERVICES, PackageTaskID.RUN_POST_IMAGE_USER_SCRIPT)
259263
.add()
260264
.task(InternalPackageType.SUPPORT)
261-
.addDependencies(PkgPackageTaskID.PREPARE_SERVICES)
262265
.action(this::buildSupportPKG)
266+
.addDependencies(PkgPackageTaskID.PREPARE_SERVICES, PackageTaskID.RUN_POST_IMAGE_USER_SCRIPT)
263267
.add()
264268
.task(InternalPackageType.MAIN)
265269
.action(this::buildMainPKG)
266-
.addDependencies(PkgPackageTaskID.PREPARE_MAIN_SCRIPTS)
270+
.addDependencies(PkgPackageTaskID.PREPARE_MAIN_SCRIPTS, PackageTaskID.RUN_POST_IMAGE_USER_SCRIPT)
267271
.add();
268272

269273
final List<TaskID> disabledTasks = new ArrayList<>();

0 commit comments

Comments
 (0)