Skip to content

Commit 51ab526

Browse files
Remove dead code. Exception with error.no.name can not be thrown from WinMsiBundler.prepareProto() because app name is validated earlier.
1 parent 196f28c commit 51ab526

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinMsiBundler.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
import java.util.LinkedHashSet;
4242
import java.util.List;
4343
import java.util.Map;
44+
import java.util.Objects;
4445
import java.util.Optional;
4546
import java.util.Set;
4647
import java.util.UUID;
@@ -349,12 +350,8 @@ public boolean validate(Map<String, ? super Object> params)
349350
private void prepareProto(Map<String, ? super Object> params)
350351
throws PackagerException, IOException {
351352
Path appImage = StandardBundlerParam.getPredefinedAppImage(params);
352-
String appName = APP_NAME.fetchFrom(params);
353+
String appName = Objects.requireNonNull(APP_NAME.fetchFrom(params));
353354
Path appDir;
354-
if (appName == null) {
355-
// Can happen when no name is given, and using a foreign app-image
356-
throw new PackagerException("error.no.name");
357-
}
358355

359356
// we either have an application image or need to build one
360357
if (appImage != null) {

0 commit comments

Comments
 (0)