Skip to content

Commit 534c5ff

Browse files
Remove dead code. message.app-image-requires-app-name can not be reported because if name is not explicitly specified, jpackage will use name from the external app image. In other words, there is no need to set app name if --app-image is specified.
1 parent 48f235a commit 534c5ff

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacBaseInstallerBundler.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -151,12 +151,6 @@ protected void validateAppImageAndBundeler(
151151
"message.app-image-dir-does-not-exist.advice"),
152152
PREDEFINED_APP_IMAGE.getID()));
153153
}
154-
if (APP_NAME.fetchFrom(params) == null) {
155-
throw new ConfigException(
156-
I18N.getString("message.app-image-requires-app-name"),
157-
I18N.getString(
158-
"message.app-image-requires-app-name.advice"));
159-
}
160154
if (AppImageFile.load(applicationImage).isSigned()) {
161155
if (!Files.exists(
162156
PackageFile.getPathInAppImage(applicationImage))) {

src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/MacResources.properties

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,6 @@ message.keychain.error=Error: unable to get keychain list.
7474
message.building-bundle=Building Mac App Store Package for {0}.
7575
message.app-image-dir-does-not-exist=Specified application image directory {0}: {1} does not exists.
7676
message.app-image-dir-does-not-exist.advice=Confirm that the value for {0} exists.
77-
message.app-image-requires-app-name=When using an external app image you must specify the app name.
78-
message.app-image-requires-app-name.advice=Set the app name via the -name CLI flag, the fx:application/@name ANT attribute, or via the 'appName' bundler argument.
7977
message.invalid-identifier=invalid mac bundle identifier [{0}].
8078
message.invalid-identifier.advice=specify identifier with "--mac-package-identifier".
8179
message.building-dmg=Building DMG package for {0}.

0 commit comments

Comments
 (0)